Skip to content

Commit 2759709

Browse files
TrottMylesBorins
authored andcommitted
test: replace map() with forEach() where appropriate
Two tests were using Array.prototype.map() without returning values in the callback. In other words, they were using it where a `.forEach()` was called for. Change to `.forEach()`. PR-URL: #17858 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent b1bc768 commit 2759709

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

test/parallel/test-https-options-boolean-check.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
6464
[false, [certStr, certStr2]],
6565
[[{ pem: keyBuff }], false],
6666
[[{ pem: keyBuff }, { pem: keyBuff }], false]
67-
].map((params) => {
67+
].forEach((params) => {
6868
assert.doesNotThrow(() => {
6969
https.createServer({
7070
key: params[0],
@@ -100,7 +100,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
100100
[[keyStr, keyStr2], [true, false], invalidCertRE],
101101
[[keyStr, keyStr2], true, invalidCertRE],
102102
[true, [certBuff, certBuff2], invalidKeyRE]
103-
].map((params) => {
103+
].forEach((params) => {
104104
common.expectsError(() => {
105105
https.createServer({
106106
key: params[0],
@@ -123,7 +123,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
123123
[keyBuff, certBuff, caArrBuff],
124124
[keyBuff, certBuff, caArrDataView],
125125
[keyBuff, certBuff, false],
126-
].map((params) => {
126+
].forEach((params) => {
127127
assert.doesNotThrow(() => {
128128
https.createServer({
129129
key: params[0],
@@ -141,7 +141,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
141141
[keyBuff, certBuff, 1],
142142
[keyBuff, certBuff, true],
143143
[keyBuff, certBuff, [caCert, true]]
144-
].map((params) => {
144+
].forEach((params) => {
145145
common.expectsError(() => {
146146
https.createServer({
147147
key: params[0],

test/parallel/test-tls-options-boolean-check.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
6464
[false, [certStr, certStr2]],
6565
[[{ pem: keyBuff }], false],
6666
[[{ pem: keyBuff }, { pem: keyBuff }], false]
67-
].map(([key, cert]) => {
67+
].forEach(([key, cert]) => {
6868
assert.doesNotThrow(() => {
6969
tls.createServer({ key, cert });
7070
});
@@ -97,7 +97,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
9797
[[keyStr, keyStr2], [true, false], invalidCertRE],
9898
[[keyStr, keyStr2], true, invalidCertRE],
9999
[true, [certBuff, certBuff2], invalidKeyRE]
100-
].map(([key, cert, message]) => {
100+
].forEach(([key, cert, message]) => {
101101
common.expectsError(() => {
102102
tls.createServer({ key, cert });
103103
}, {
@@ -117,7 +117,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
117117
[keyBuff, certBuff, caArrBuff],
118118
[keyBuff, certBuff, caArrDataView],
119119
[keyBuff, certBuff, false],
120-
].map(([key, cert, ca]) => {
120+
].forEach(([key, cert, ca]) => {
121121
assert.doesNotThrow(() => {
122122
tls.createServer({ key, cert, ca });
123123
});
@@ -131,7 +131,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
131131
[keyBuff, certBuff, 1],
132132
[keyBuff, certBuff, true],
133133
[keyBuff, certBuff, [caCert, true]]
134-
].map(([key, cert, ca]) => {
134+
].forEach(([key, cert, ca]) => {
135135
common.expectsError(() => {
136136
tls.createServer({ key, cert, ca });
137137
}, {
@@ -149,7 +149,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
149149
[keyBuff, certBuff, 1],
150150
[keyBuff, certBuff, true],
151151
[keyBuff, certBuff, [caCert, true]]
152-
].map(([key, cert, ca]) => {
152+
].forEach(([key, cert, ca]) => {
153153
common.expectsError(() => {
154154
tls.createServer({ key, cert, ca });
155155
}, {
@@ -167,7 +167,7 @@ const invalidCertRE = /^The "cert" argument must be one of type string, Buffer,
167167
[undefined, undefined, undefined],
168168
['', '', ''],
169169
[0, 0, 0]
170-
].map(([key, cert, ca]) => {
170+
].forEach(([key, cert, ca]) => {
171171
assert.doesNotThrow(() => {
172172
tls.createSecureContext({ key, cert, ca });
173173
});

0 commit comments

Comments
 (0)