test: fix flaky parallel/test-http2-client-upload

In parallel/test-http2-client-upload, the `client.destroy()`
call could terminate the connection before all data was sent
over the wire successfully.

Using `client.shutdown()` removes the flakiness.

Also, listen on `req.on('finish')` rather than the file stream’s
`end` event, since we’re not interested in when the source stream
finishes, but rather when the HTTP/2 stream finishes.

PR-URL: #17361
Refs: #17356
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Jon Moss <[email protected]>

Author: addaleax

test/parallel/test-http2-client-upload.js

@@ -38,7 +38,7 @@ fs.readFile(loc, common.mustCall((err, data) => {
     function maybeClose() {
       if (--remaining === 0) {
         server.close();
-        client.destroy();
+        client.shutdown();
       }
     }
 
@@ -47,7 +47,7 @@ fs.readFile(loc, common.mustCall((err, data) => {
     req.resume();
     req.on('end', common.mustCall(maybeClose));
     const str = fs.createReadStream(loc);
-    str.on('end', common.mustCall(maybeClose));
+    req.on('finish', common.mustCall(maybeClose));
     str.pipe(req);
   }));
 }));