Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 153f5ed

Browse files
richardlaucodebytere
authored andcommittedJun 18, 2020
build: fix compiling addons with older versions of Node.js
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: #33688 Refs: #30463 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Signed-off-by: Richard Lau <[email protected]>
1 parent e7bce2e commit 153f5ed

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed
 

‎common.gypi

+6
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@
5757
# https://github.com/nodejs/node/pull/22920/files#r222779926
5858
'v8_enable_handle_zapping': 0,
5959

60+
# Disable pointer compression. Can be enabled at build time via configure
61+
# options but default values are required here as this file is also used by
62+
# node-gyp to build addons.
63+
'v8_enable_pointer_compression%': 0,
64+
'v8_enable_31bit_smis_on_64bit_arch%': 0,
65+
6066
# Disable V8 untrusted code mitigations.
6167
# See https://github.com/v8/v8/wiki/Untrusted-code-mitigations
6268
'v8_untrusted_code_mitigations': 0,

0 commit comments

Comments
 (0)
Please sign in to comment.