Skip to content

Commit 0ca9019

Browse files
mhdawsonmarco-ippolito
authored andcommitted
crypto: add missing return value check
Add return value check for call to SSL_CTX_add_client_CA to be consistent with other places it is called Fixed unused warning in one of the static analysis tools we use at Red Hat even though it is not being reported by coverity in the configuration we run. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #56615 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 96f1baf commit 0ca9019

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/crypto/crypto_context.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1117,7 +1117,7 @@ void SecureContext::LoadPKCS12(const FunctionCallbackInfo<Value>& args) {
11171117
X509* ca = sk_X509_value(extra_certs.get(), i);
11181118

11191119
X509_STORE_add_cert(sc->GetCertStoreOwnedByThisSecureContext(), ca);
1120-
SSL_CTX_add_client_CA(sc->ctx_.get(), ca);
1120+
CHECK_EQ(1, SSL_CTX_add_client_CA(sc->ctx_.get(), ca));
11211121
}
11221122
ret = true;
11231123

0 commit comments

Comments
 (0)