Skip to content

Commit 0aaab45

Browse files
UlisesGasconrichardlau
authored andcommitted
tools: improve macOS notarization process output readability
PR-URL: #50389 Fixes: nodejs/build#3529 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent ad32603 commit 0aaab45

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

tools/osx-notarize.sh

+10-13
Original file line numberDiff line numberDiff line change
@@ -37,22 +37,19 @@ fi
3737
# Submit the package for notarization
3838
# TODO(@ulisesGascon): refactor to use --keychain-profile
3939
# when https://github.com/nodejs/build/issues/3385#issuecomment-1729281269 is ready
40-
notarization_output=$(
41-
xcrun notarytool submit \
42-
--apple-id "$NOTARIZATION_ID" \
43-
--password "$NOTARIZATION_PASSWORD" \
44-
--team-id "$NOTARIZATION_TEAM_ID" \
45-
--wait \
46-
"node-$pkgid.pkg" 2>&1
47-
)
40+
echo "Submitting node-$pkgid.pkg for notarization..."
41+
42+
xcrun notarytool submit \
43+
--apple-id "$NOTARIZATION_ID" \
44+
--password "$NOTARIZATION_PASSWORD" \
45+
--team-id "$NOTARIZATION_TEAM_ID" \
46+
--wait \
47+
"node-$pkgid.pkg"
4848

4949
if [ $? -eq 0 ]; then
50-
# Extract the operation ID from the output
51-
operation_id=$(echo "$notarization_output" | awk '/RequestUUID/ {print $NF}')
52-
echo "Notarization submitted. Operation ID: $operation_id"
50+
echo "Notarization node-$pkgid.pkg submitted successfully."
5351
exit 0
5452
else
55-
echo "Notarization failed. Error: $notarization_output"
53+
echo "Notarization node-$pkgid.pkg failed."
5654
exit 1
5755
fi
58-

0 commit comments

Comments
 (0)