From f392c8ab3cef53ecb443c2881e3624778143f3ff Mon Sep 17 00:00:00 2001 From: Feng Yu <F3n67u@outlook.com> Date: Sat, 1 Oct 2022 22:28:23 +0800 Subject: [PATCH 1/2] docs: fix typo in git-node.md --- docs/git-node.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/git-node.md b/docs/git-node.md index c8e4d5fa..5d5314ae 100644 --- a/docs/git-node.md +++ b/docs/git-node.md @@ -166,8 +166,8 @@ Options: ### Optional Settings -The same Settings used by -[`git node metadata`](#git-node-metadata-optional-settings) are also used by +The same Settings used by +[`git node metadata`](#git-node-metadata-optional-settings) are also used by `git node land`. ## `git node backport` @@ -316,7 +316,7 @@ ncu-config set waitTimeMultiApproval 48 ## `git node v8` -Update or patch the V8 engine. +Update or patch the V8 engine. This tool will maintain a clone of the V8 repository in `~/.update-v8/v8` if it's used without `--v8-dir`. @@ -334,7 +334,7 @@ $ brew install gpatch And make sure `which patch` points to `/usr/local/bin/patch` installed by homebrew instead of `/usr/bin/patch` that comes with the system (e.g. by -modifying yoru `PATH` environment variable). +modifying your `PATH` environment variable). ### `git node v8 major` @@ -353,7 +353,7 @@ Options: ### `git node v8 minor` Compare current V8 version with latest upstream of the same major. Applies a -patch if necessary. +patch if necessary. If the `git apply` command fails, a patch file will be written in the Node.js clone directory. From 0065af47b8d613e7a14566497f87623b3c5b54c6 Mon Sep 17 00:00:00 2001 From: Feng Yu <F3n67u@outlook.com> Date: Sun, 9 Oct 2022 22:01:37 +0800 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> --- docs/git-node.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/git-node.md b/docs/git-node.md index 5d5314ae..6b22205f 100644 --- a/docs/git-node.md +++ b/docs/git-node.md @@ -316,7 +316,7 @@ ncu-config set waitTimeMultiApproval 48 ## `git node v8` -Update or patch the V8 engine. +Update or patch the V8 engine. This tool will maintain a clone of the V8 repository in `~/.update-v8/v8` if it's used without `--v8-dir`. @@ -353,7 +353,7 @@ Options: ### `git node v8 minor` Compare current V8 version with latest upstream of the same major. Applies a -patch if necessary. +patch if necessary. If the `git apply` command fails, a patch file will be written in the Node.js clone directory.