diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d860e35..250babef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## [2.1.1](https://github.com/nodejs/node-core-utils/compare/v2.1.0...v2.1.1) (2022-10-27) + + +### Bug Fixes + +* add missing await ([#655](https://github.com/nodejs/node-core-utils/issues/655)) ([7e4dc88](https://github.com/nodejs/node-core-utils/commit/7e4dc886f7b2030457cda5d89bb84759a0012466)) + ## [2.1.0](https://github.com/nodejs/node-core-utils/compare/v2.0.1...v2.1.0) (2022-10-22) diff --git a/README.md b/README.md index f8fd4b16..60e0a361 100644 --- a/README.md +++ b/README.md @@ -100,7 +100,7 @@ To obtain the Jenkins API token token in the inbox that appears, and click `GENERATE`. 4. Copy the generated token. 5. Add it into your `ncurc` file (`~/.ncurc` or `$XDG_CONFIG_HOME/ncurc`) - with `jenkins_token` as key, like this + with `jenkins_token` as key, like this: ```json { @@ -113,7 +113,9 @@ To obtain the Jenkins API token ### Make sure your credentials won't be committed -Put the following entries into `~/.gitignore_global` +Put the following entries into your +[global `gitignore` file](https://git-scm.com/docs/git-config#Documentation/git-config.txt-coreexcludesFile) +(`$XDG_CONFIG_HOME/git/ignore` or a file specified by `core.excludesFile`): ``` # node-core-utils configuration file @@ -122,7 +124,7 @@ Put the following entries into `~/.gitignore_global` .ncu ``` -Mind that`.ncu/land` could contain your access token since it contains the +Mind that `.ncu/land` could contain your access token since it contains the serialized configurations. If you ever accidentally commit your access token on GitHub, you can simply diff --git a/bin/ncu-ci.js b/bin/ncu-ci.js index d0fd8bf1..0d013ac9 100755 --- a/bin/ncu-ci.js +++ b/bin/ncu-ci.js @@ -286,7 +286,7 @@ class RunPRJobCommand { return; } const jobRunner = new RunPRJob(cli, request, owner, repo, prid); - if (!jobRunner.start()) { + if (!(await jobRunner.start())) { this.cli.setExitCode(1); process.exitCode = 1; } diff --git a/components/git/release.js b/components/git/release.js index 29d2ba30..e20db483 100644 --- a/components/git/release.js +++ b/components/git/release.js @@ -36,7 +36,9 @@ export function builder(yargs) { describe: 'Version number of the release to be prepared or promoted' }) .example('git node release --prepare 1.2.3', - 'Prepare a new release of Node.js tagged v1.2.3'); + 'Prepare a release of Node.js tagged v1.2.3') + .example('git node --prepare --startLTS', + 'Prepare the first LTS release'); } export function handler(argv) { diff --git a/docs/git-node.md b/docs/git-node.md index 6b22205f..79c6000e 100644 --- a/docs/git-node.md +++ b/docs/git-node.md @@ -233,6 +233,11 @@ git node release --prepare 1.2.3 git node release --prepare ``` +```sh +# Prepare the first LTS release for a given release line +git node release --prepare --startLTS +``` + ## `git node sync` Demo: https://asciinema.org/a/221230 diff --git a/docs/ncu-ci.md b/docs/ncu-ci.md index 85aa105d..967a862f 100644 --- a/docs/ncu-ci.md +++ b/docs/ncu-ci.md @@ -111,7 +111,7 @@ and then cache the responses from Jenkins so that the next time the command is run, it picks up cached data written on disk for jobs whose results are known. -Note: results are cached in `${ncu_intallation_path}/.ncu/cache`, so you +Note: results are cached in `${ncu_installation_path}/.ncu/cache`, so you may want to clean it up from time to time. ``` diff --git a/package.json b/package.json index 182dd40b..64e8063f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-core-utils", - "version": "2.1.0", + "version": "2.1.1", "description": "Utilities for Node.js core collaborators", "type": "module", "bin": {