diff --git a/.github/workflows/commitlint.yml b/.github/workflows/commitlint.yml index 4799fc884..1e8c983e1 100644 --- a/.github/workflows/commitlint.yml +++ b/.github/workflows/commitlint.yml @@ -13,6 +13,4 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 100 - - uses: wagoid/commitlint-github-action@v2 - with: - token: ${{ secrets.GITHUB_TOKEN }} + - uses: wagoid/commitlint-github-action@v4 diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 1b1cd9eb1..d0fb4023c 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -26,7 +26,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [12.x, 14.x, 16.x, 17.x] + node-version: [14.x, 16.x, 18.x] os: [ubuntu-latest, macOS-latest, windows-latest] runs-on: ${{ matrix.os }} steps: @@ -40,4 +40,4 @@ jobs: - name: Run tests run: npm run coverage-all - name: Upload coverage report to Codecov - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v3 diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index dbaedc3cf..0006f4c0a 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -14,7 +14,6 @@ jobs: - uses: google-github-actions/release-please-action@v3 id: release with: - token: ${{ secrets.GITHUB_TOKEN }} release-type: node package-name: node-core-utils npm-publish: @@ -25,7 +24,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16.x + node-version: lts/* registry-url: 'https://registry.npmjs.org' - run: npm publish env: diff --git a/CHANGELOG.md b/CHANGELOG.md index 8f0fb70f9..530a87d9f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,21 @@ # Changelog +## [2.0.0](https://github.com/nodejs/node-core-utils/compare/v1.31.4...v2.0.0) (2022-06-22) + + +### ⚠ BREAKING CHANGES + +* **ci:** Removed support for Node.js 12 and 17. + +### Bug Fixes + +* broken enquirer in listr2 ([#636](https://github.com/nodejs/node-core-utils/issues/636)) ([460b50d](https://github.com/nodejs/node-core-utils/commit/460b50dcea878a6234021448441395efefaeb2bf)) + + +### Miscellaneous Chores + +* **ci:** test on supported Node.js versions ([40a1ee2](https://github.com/nodejs/node-core-utils/commit/40a1ee220b058a1ce2b6e513d75d2a5ea0124633)) + ### [1.31.4](https://github.com/nodejs/node-core-utils/compare/v1.31.3...v1.31.4) (2022-04-25) diff --git a/components/git/backport.js b/components/git/backport.js index 60f67cbbc..0add653bc 100644 --- a/components/git/backport.js +++ b/components/git/backport.js @@ -10,12 +10,12 @@ const epilogue = `====================== Example ======================= Demo: https://asciinema.org/a/221244 Backporting https://github.com/nodejs/node/pull/24816 to v11.x -# Sync master with upstream for the commits, if they are not yet there -$ git checkout master -$ ncu-config set branch master +# Sync main with upstream for the commits, if they are not yet there +$ git checkout main +$ ncu-config set branch main $ git node sync -# Backport existing commits from master to v11.x-staging +# Backport existing commits from main to v11.x-staging $ git checkout v11.x-staging $ ncu-config set branch v11.x-staging $ git node sync diff --git a/components/git/epilogue.js b/components/git/epilogue.js index 2482a02f0..077e3cfda 100644 --- a/components/git/epilogue.js +++ b/components/git/epilogue.js @@ -4,9 +4,9 @@ $ cd path/to/node/project # If you have not configured it before $ ncu-config set upstream <name-of-remote-to-nodejs/node> -$ ncu-config set branch master # Assuming you are landing commits on master +$ ncu-config set branch main # Assuming you are landing commits on main -$ git checkout master +$ git checkout main $ git node land --abort # Abort a landing session, just in case $ git node land $PRID # Start a new landing session $ git node land $URL # Start a new landing session using the PR URL diff --git a/docs/git-node.md b/docs/git-node.md index 55a6074cb..c8e4d5fa1 100644 --- a/docs/git-node.md +++ b/docs/git-node.md @@ -3,28 +3,29 @@ A custom Git command for managing pull requests. You can run it as `git-node` or `git node`. To see the help text, run `git node`. -- [`git node land`](#git-node-land) - - [Prerequisites](#git-node-land-prerequisites) - - [Git bash for Windows](#git-bash-for-windows) - - [Demo & Usage](#demo--usage) - - [Optional Settings](#git-node-land-optional-settings) -- [`git node backport`](#git-node-backport) - - [Example](#example) -- [`git node release`](#git-node-release) - - [Example](#example-1) -- [`git node sync`](#git-node-sync) -- [`git node metadata`](#git-node-metadata) - - [Optional Settings](#git-node-metadata-optional-settings) -- [`git node v8`](#git-node-v8) - - [Prerequisites](#git-node-v8-prerequisites) - - [`git node v8 major`](#git-node-v8-major) - - [`git node v8 minor`](#git-node-v8-minor) - - [`git node v8 backport <sha..>`](#git-node-v8-backport-sha) - - [General options](#general-options) -- [`git node status`](#git-node-status) - - [Example](#example) -- [`git node wpt`](#git-node-wpt) - - [Example](#example-2) +- [git-node](#git-node) + - [`git node land`](#git-node-land) + - [Prerequisites](#prerequisites) + - [Git bash for Windows](#git-bash-for-windows) + - [Demo & Usage](#demo--usage) + - [Optional Settings](#optional-settings) + - [`git node backport`](#git-node-backport) + - [Example](#example) + - [`git node release`](#git-node-release) + - [Example](#example-1) + - [`git node sync`](#git-node-sync) + - [`git node metadata`](#git-node-metadata) + - [Optional Settings](#optional-settings-1) + - [`git node v8`](#git-node-v8) + - [Prerequisites](#prerequisites-1) + - [`git node v8 major`](#git-node-v8-major) + - [`git node v8 minor`](#git-node-v8-minor) + - [`git node v8 backport <sha..>`](#git-node-v8-backport-sha) + - [General options](#general-options) + - [`git node status`](#git-node-status) + - [Example](#example-2) + - [`git node wpt`](#git-node-wpt) + - [Example](#example-3) ## `git node land` @@ -93,8 +94,8 @@ Examples: # Tell ncu that your upstream remote is named "upstream" $ ncu-config set upstream upstream - # Tell ncu that you are landing patches to "master" branch - $ ncu-config set branch master + # Tell ncu that you are landing patches to "main" branch + $ ncu-config set branch main ``` Note: If you are behind a firewall and run into `ECONNREFUSED` issues with @@ -130,9 +131,9 @@ $ cd path/to/node/project # If you have not configured it before $ ncu-config set upstream <name-of-remote-to-nodejs/node> -$ ncu-config set branch master # Assuming you are landing commits on master +$ ncu-config set branch main # Assuming you are landing commits on main -$ git checkout master +$ git checkout main $ git node land --abort # Abort a landing session, just in case $ git node land $PRID # Start a new landing session $ git node land $URL # Start a new landing session using the PR URL @@ -192,11 +193,11 @@ Options: ``` Backporting https://github.com/nodejs/node/pull/12344 to v10.x -# Sync master with upstream for the commits, if they are not yet there -$ git checkout master +# Sync main with upstream for the commits, if they are not yet there +$ git checkout main $ git node sync -# Backport existing commits from master to v10.x-staging +# Backport existing commits from main to v10.x-staging $ git checkout v10.x-staging $ git node sync $ git node backport 12344 --to 10 @@ -397,14 +398,14 @@ Return status and information about the current git-node land session. Shows the ### Example ```sh -node on git:master ❯ git node status 11:32AM +node on git:main ❯ git node status 11:32AM ✔ Landing session in progress -------------------------------------------------------------------------------- PR: https:/github.com/nodejs/node/pull/34800 State: AMENDING Username: codebytere Upstream: upstream -Branch: master +Branch: main ``` ## `git node wpt` @@ -441,4 +442,4 @@ $ git node wpt url # Will update test/fixtures/wpt/url and related files $ git node wpt url --commit=43feb7f612fe9160639e09a47933a29834904d69 ``` -[node.js abi version registry]: https://github.com/nodejs/node/blob/master/doc/abi_version_registry.json +[node.js abi version registry]: https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json diff --git a/docs/ncu-ci.md b/docs/ncu-ci.md index 423a7b49c..85aa105d1 100644 --- a/docs/ncu-ci.md +++ b/docs/ncu-ci.md @@ -42,7 +42,7 @@ Options: Examples: ```sh -node on git:master ❯ ncu-ci rate pr +node on git:main ❯ ncu-ci rate pr -------------------------------------------------------------------------------- [1/1] Running health -------------------------------------------------------------------------------- @@ -53,7 +53,7 @@ node on git:master ❯ ncu-ci rate pr ``` ```sh -node on git:master ❯ ncu-ci rate commit +node on git:main ❯ ncu-ci rate commit -------------------------------------------------------------------------------- [1/1] Running health -------------------------------------------------------------------------------- @@ -69,7 +69,7 @@ node on git:master ❯ ncu-ci rate commit Example: ```sh -node on git:master ❯ ncu-ci walk commit +node on git:main ❯ ncu-ci walk commit ✔ Done-------------------------------------------------------------------------------- [1/60] Running health -------------------------------------------------------------------------------- @@ -133,7 +133,7 @@ For example, if you would like to see the results of `node-test-pull-request` fo Example: ```sh -node on git:master ❯ ncu-ci pr 32158 +node on git:main ❯ ncu-ci pr 32158 -------------------------------------------------------------------------------- [1/1] Running PR: 32158 -------------------------------------------------------------------------------- @@ -157,7 +157,7 @@ For example, if you would like to see the results of `node-test-commit` for http Example: ```sh -node on git:master ❯ ncu-ci commit 39377 +node on git:main ❯ ncu-ci commit 39377 -------------------------------------------------------------------------------- [1/1] Running COMMIT: 39377 -------------------------------------------------------------------------------- @@ -180,7 +180,7 @@ Unstable https://ci.nodejs.org/job/node-test-commit-arm-fanned/15148/ Example: ```sh -node on git:master ❯ ncu-ci url https://github.com/nodejs/node/pull/34127 +node on git:main ❯ ncu-ci url https://github.com/nodejs/node/pull/34127 -------------------------------------------------------------------------------- [1/1] Running PR: 32158 -------------------------------------------------------------------------------- @@ -202,7 +202,7 @@ Unstable https://ci.nodejs.org/job/node-test-commit-arm-fanned/15155/ Example: ```sh -node on git:master ❯ ncu-ci benchmark 636 +node on git:main ❯ ncu-ci benchmark 636 -------------------------------------------------------------------------------- [1/1] Running BENCHMARK: 636 -------------------------------------------------------------------------------- @@ -237,7 +237,7 @@ Finished: SUCCESS Example: ``` -node on git:master ❯ ncu-ci citgm 2400 +node on git:main ❯ ncu-ci citgm 2400 -------------------------------------------------------------------------------- [1/1] Running CITGM: 2400 -------------------------------------------------------------------------------- @@ -316,7 +316,7 @@ FAILURE: 5 failures in 2390 not present in 2392 `ncu-ci daily` show recent results of `node-daily-master`. You can also aggregate the results by passing `--cache`, or limit the maximum number of CIs jobs to get data from with `--limit=N`. See `ncu-ci daily --help` for more. ```sh -node on git:master ❯ ncu-ci daily +node on git:main ❯ ncu-ci daily ✔ Done-------------------------------------------------------------------------------- [1/16] Running health -------------------------------------------------------------------------------- @@ -333,7 +333,7 @@ node on git:master ❯ ncu-ci daily ----------------------------------- Summary ------------------------------------ Result FAILURE URL https://ci.nodejs.org/job/node-test-commit/39692/ -Source https://api.github.com/repos/nodejs/node/git/refs/heads/master +Source https://api.github.com/repos/nodejs/node/git/refs/heads/main Commit [bf0d82c10247] test: remove common.localhostIPv6 Date 2020-07-16 16:57:30 -0700 Author Rich Trott <rtrott@gmail.com> diff --git a/lib/backport_session.js b/lib/backport_session.js index 3a871ccbb..f45a86f89 100644 --- a/lib/backport_session.js +++ b/lib/backport_session.js @@ -141,9 +141,9 @@ export default class BackportSession extends Session { // TODO(joyeechuneg): add more warnings const { prid } = this; const url = getPrURL(this); - cli.log(`Looking for commits of ${url} on master...`); + cli.log(`Looking for commits of ${url} on main...`); - const commits = this.getCommitsFromBranch(prid, 'master'); + const commits = this.getCommitsFromBranch(prid, 'main'); if (commits.length === 0) { cli.error('Could not find any commit matching the PR'); diff --git a/lib/collaborators.js b/lib/collaborators.js index 2bb25f067..4ff93d0bc 100644 --- a/lib/collaborators.js +++ b/lib/collaborators.js @@ -68,7 +68,7 @@ export async function getCollaborators(cli, request, argv) { function parseCollaborators(readme, cli) { // This is more or less taken from - // https://github.com/rvagg/archived-iojs-tools/blob/master/pr-metadata/pr-metadata.js + // https://github.com/rvagg/archived-iojs-tools/blob/main/pr-metadata/pr-metadata.js const collaborators = new Map(); let m; diff --git a/lib/prepare_release.js b/lib/prepare_release.js index fc918fc8a..750eab2a8 100644 --- a/lib/prepare_release.js +++ b/lib/prepare_release.js @@ -587,7 +587,7 @@ export default class ReleasePreparation { 'baking-for-lts' ]; - let comparisonBranch = 'master'; + let comparisonBranch = 'main'; const isSemverMinor = versionComponents.patch === 0; if (isLTS) { // Assume Current branch matches tag with highest semver value. diff --git a/lib/session.js b/lib/session.js index 9200930e4..18256c56f 100644 --- a/lib/session.js +++ b/lib/session.js @@ -369,8 +369,8 @@ export default class Session { cli.separator(); cli.info( 'For example, if your want to land commits on the ' + - '`master` branch, you can run:\n\n' + - ' $ ncu-config set branch master'); + '`main` branch, you can run:\n\n' + + ' $ ncu-config set branch main'); cli.separator(); cli.setExitCode(1); } diff --git a/lib/update-v8/applyNodeChanges.js b/lib/update-v8/applyNodeChanges.js index 806e1d253..3dbfd2469 100644 --- a/lib/update-v8/applyNodeChanges.js +++ b/lib/update-v8/applyNodeChanges.js @@ -1,5 +1,6 @@ import path from 'node:path'; +import Enquirer from 'enquirer'; import { Listr } from 'listr2'; import { @@ -22,7 +23,11 @@ export default function applyNodeChanges() { task: async(ctx) => { const v8Version = await getNodeV8Version(ctx.nodeDir); const list = filterForVersion(nodeChanges, v8Version); - return new Listr(list.map((change) => change.task())); + return new Listr(list.map((change) => change.task()), { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; } diff --git a/lib/update-v8/backport.js b/lib/update-v8/backport.js index 8bc86c5ac..d3d2fca08 100644 --- a/lib/update-v8/backport.js +++ b/lib/update-v8/backport.js @@ -3,6 +3,7 @@ import { promises as fs } from 'node:fs'; +import Enquirer from 'enquirer'; import inquirer from 'inquirer'; import { Listr } from 'listr2'; @@ -50,7 +51,11 @@ export function doBackport(options) { return { title: 'V8 commit backport', task: () => { - return new Listr(todo); + return new Listr(todo, { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; }; @@ -168,7 +173,11 @@ function applyAndCommitPatches() { return { title: 'Apply and commit patches to deps/v8', task: (ctx) => { - return new Listr(ctx.patches.map(applyPatchTask)); + return new Listr(ctx.patches.map(applyPatchTask), { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; } @@ -191,7 +200,11 @@ function applyPatchTask(patch) { } } todo.push(commitPatch(patch)); - return new Listr(todo); + return new Listr(todo, { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; } diff --git a/lib/update-v8/index.js b/lib/update-v8/index.js index cbb528ae0..0fa6c5368 100644 --- a/lib/update-v8/index.js +++ b/lib/update-v8/index.js @@ -1,3 +1,4 @@ +import Enquirer from 'enquirer'; import { Listr } from 'listr2'; import { checkOptions, doBackport } from './backport.js'; @@ -33,8 +34,16 @@ export async function backport(options) { return tasks.run(options); }; +/** + * Get the listr2 options. + * @param {{ verbose?: boolean }} options The original options. + * @return {import('listr2').ListrOptions} The listr2 options. + */ function getOptions(opts) { return { - renderer: opts.verbose ? 'verbose' : 'default' + renderer: opts.verbose ? 'verbose' : 'default', + injectWrapper: { + enquirer: new Enquirer() + } }; } diff --git a/lib/update-v8/majorUpdate.js b/lib/update-v8/majorUpdate.js index cf376ffd6..10d74826c 100644 --- a/lib/update-v8/majorUpdate.js +++ b/lib/update-v8/majorUpdate.js @@ -1,6 +1,7 @@ import path from 'node:path'; import { promises as fs } from 'node:fs'; +import Enquirer from 'enquirer'; import { execa } from 'execa'; import { Listr } from 'listr2'; @@ -28,7 +29,11 @@ export default function majorUpdate() { addDepsV8(), updateV8Deps(), applyNodeChanges() - ]); + ], { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; }; diff --git a/lib/update-v8/minorUpdate.js b/lib/update-v8/minorUpdate.js index cb5bc8fcb..0c50d0fb7 100644 --- a/lib/update-v8/minorUpdate.js +++ b/lib/update-v8/minorUpdate.js @@ -1,6 +1,7 @@ import path from 'node:path'; import { promises as fs } from 'node:fs'; +import Enquirer from 'enquirer'; import { execa } from 'execa'; import { Listr } from 'listr2'; @@ -14,7 +15,11 @@ export default function minorUpdate() { getCurrentV8Version(), getLatestV8Version(), doMinorUpdate() - ]); + ], { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; }; diff --git a/lib/update-v8/updateV8Clone.js b/lib/update-v8/updateV8Clone.js index 37004af25..1f8fb5eba 100644 --- a/lib/update-v8/updateV8Clone.js +++ b/lib/update-v8/updateV8Clone.js @@ -1,5 +1,6 @@ import { promises as fs } from 'node:fs'; +import Enquirer from 'enquirer'; import { execa } from 'execa'; import { Listr } from 'listr2'; @@ -9,7 +10,11 @@ export default function updateV8Clone() { return { title: 'Update local V8 clone', task: () => { - return new Listr([fetchOrigin(), createClone()]); + return new Listr([fetchOrigin(), createClone()], { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; }; diff --git a/lib/update-v8/updateVersionNumbers.js b/lib/update-v8/updateVersionNumbers.js index 5c832e081..abbe6b454 100644 --- a/lib/update-v8/updateVersionNumbers.js +++ b/lib/update-v8/updateVersionNumbers.js @@ -1,6 +1,7 @@ import path from 'node:path'; import { promises as fs } from 'node:fs'; +import Enquirer from 'enquirer'; import { Listr } from 'listr2'; import { getNodeV8Version } from './util.js'; @@ -9,7 +10,11 @@ export default function updateVersionNumbers() { return { title: 'Update version numbers', task: () => { - return new Listr([resetEmbedderString(), bumpNodeModule()]); + return new Listr([resetEmbedderString(), bumpNodeModule()], { + injectWrapper: { + enquirer: new Enquirer() + } + }); } }; }; diff --git a/package.json b/package.json index 1066c64d6..6f2c41fa8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-core-utils", - "version": "1.31.4", + "version": "2.0.0", "description": "Utilities for Node.js core collaborators", "type": "module", "bin": { @@ -37,31 +37,32 @@ "cheerio": "^1.0.0-rc.10", "clipboardy": "^3.0.0", "core-validate-commit": "^3.16.0", + "enquirer": "^2.3.6", "execa": "^6.1.0", "figures": "^4.0.1", "form-data": "^4.0.0", "ghauth": "^4.0.0", - "inquirer": "^8.2.2", + "inquirer": "^8.2.4", "listr2": "^4.0.5", "lodash": "^4.17.21", "log-symbols": "^5.1.0", - "node-fetch": "^3.2.3", + "node-fetch": "^3.2.4", "ora": "^6.1.0", "proxy-agent": "^5.0.0", "replace-in-file": "^6.3.2", "rimraf": "^3.0.2", "which": "^2.0.2", - "yargs": "^17.4.1" + "yargs": "^17.5.0" }, "devDependencies": { "c8": "^7.11.2", - "eslint": "^8.13.0", + "eslint": "^8.15.0", "eslint-config-standard": "^17.0.0", "eslint-plugin-import": "^2.26.0", "eslint-plugin-node": "^11.1.0", "eslint-plugin-promise": "^6.0.0", "eslint-plugin-standard": "^4.1.0", - "mocha": "^9.2.2", - "sinon": "^13.0.2" + "mocha": "^10.0.0", + "sinon": "^14.0.0" } } diff --git a/test/fixtures/closed_pr.json b/test/fixtures/closed_pr.json index 518c52072..0b7858ab6 100644 --- a/test/fixtures/closed_pr.json +++ b/test/fixtures/closed_pr.json @@ -17,7 +17,7 @@ ] }, "title": "testing: do not merge", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "awesome-changes", "closed": true, "closedAt": "2017-10-28T11:13:43Z", diff --git a/test/fixtures/code_and_learn_pr.json b/test/fixtures/code_and_learn_pr.json index 31ed64f7a..da26e2fb4 100644 --- a/test/fixtures/code_and_learn_pr.json +++ b/test/fixtures/code_and_learn_pr.json @@ -18,6 +18,6 @@ ] }, "title": "test: awesome changes", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "awesome-changes" } diff --git a/test/fixtures/conflicting_pr.json b/test/fixtures/conflicting_pr.json index a9cc9c849..a55a81864 100644 --- a/test/fixtures/conflicting_pr.json +++ b/test/fixtures/conflicting_pr.json @@ -15,7 +15,7 @@ ] }, "title": "test: This PR has conflicts", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "pr-conflicts", "mergeable": "CONFLICTING" } diff --git a/test/fixtures/empty_profile_pr.json b/test/fixtures/empty_profile_pr.json index 51e059865..4eca1d26c 100644 --- a/test/fixtures/empty_profile_pr.json +++ b/test/fixtures/empty_profile_pr.json @@ -17,6 +17,6 @@ ] }, "title": "doc: fix mdn links", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "fix-links" } diff --git a/test/fixtures/first_timer_pr.json b/test/fixtures/first_timer_pr.json index 8e57b7c63..0ae29b6a2 100644 --- a/test/fixtures/first_timer_pr.json +++ b/test/fixtures/first_timer_pr.json @@ -23,6 +23,6 @@ ] }, "title": "test: awesome changes", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "awesome-changes" } diff --git a/test/fixtures/first_timer_pr_with_private_email.json b/test/fixtures/first_timer_pr_with_private_email.json index a3cd5fcf8..65a61a775 100644 --- a/test/fixtures/first_timer_pr_with_private_email.json +++ b/test/fixtures/first_timer_pr_with_private_email.json @@ -20,6 +20,6 @@ ] }, "title": "test: awesome changes", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "awesome-changes" } diff --git a/test/fixtures/jenkins/benchmark-buffer/benchmark-node-micro-benchmarks-150.txt b/test/fixtures/jenkins/benchmark-buffer/benchmark-node-micro-benchmarks-150.txt index ded72cda8..4cb3b45bf 100644 --- a/test/fixtures/jenkins/benchmark-buffer/benchmark-node-micro-benchmarks-150.txt +++ b/test/fixtures/jenkins/benchmark-buffer/benchmark-node-micro-benchmarks-150.txt @@ -15,8 +15,8 @@ RUNS not set (ok) MACHINE_THREADS not set (ok), default is: 88 Cloning into 'node'... Checking out files: 42% (11166/26057) Checking out files: 43% (11205/26057) Checking out files: 44% (11466/26057) Checking out files: 45% (11726/26057) Checking out files: 46% (11987/26057) Checking out files: 47% (12247/26057) Checking out files: 48% (12508/26057) Checking out files: 49% (12768/26057) Checking out files: 50% (13029/26057) Checking out files: 51% (13290/26057) Checking out files: 52% (13550/26057) Checking out files: 53% (13811/26057) Checking out files: 54% (14071/26057) Checking out files: 55% (14332/26057) Checking out files: 56% (14592/26057) Checking out files: 57% (14853/26057) Checking out files: 58% (15114/26057) Checking out files: 59% (15374/26057) Checking out files: 60% (15635/26057) Checking out files: 61% (15895/26057) Checking out files: 62% (16156/26057) Checking out files: 63% (16416/26057) Checking out files: 64% (16677/26057) Checking out files: 65% (16938/26057) Checking out files: 66% (17198/26057) Checking out files: 67% (17459/26057) Checking out files: 68% (17719/26057) Checking out files: 69% (17980/26057) Checking out files: 70% (18240/26057) Checking out files: 71% (18501/26057) Checking out files: 72% (18762/26057) Checking out files: 73% (19022/26057) Checking out files: 74% (19283/26057) Checking out files: 75% (19543/26057) Checking out files: 76% (19804/26057) Checking out files: 77% (20064/26057) Checking out files: 78% (20325/26057) Checking out files: 79% (20586/26057) Checking out files: 80% (20846/26057) Checking out files: 81% (21107/26057) Checking out files: 82% (21367/26057) Checking out files: 83% (21628/26057) Checking out files: 84% (21888/26057) Checking out files: 85% (22149/26057) Checking out files: 86% (22410/26057) Checking out files: 87% (22670/26057) Checking out files: 88% (22931/26057) Checking out files: 89% (23191/26057) Checking out files: 90% (23452/26057) Checking out files: 91% (23712/26057) Checking out files: 92% (23973/26057) Checking out files: 93% (24234/26057) Checking out files: 94% (24494/26057) Checking out files: 95% (24755/26057) Checking out files: 96% (25015/26057) Checking out files: 97% (25276/26057) Checking out files: 98% (25536/26057) Checking out files: 99% (25797/26057) Checking out files: 100% (26057/26057) Checking out files: 100% (26057/26057), done. -Already on 'master' -Your branch is up-to-date with 'origin/master'. +Already on 'main' +Your branch is up-to-date with 'origin/main'. ../deps/icu-small/source/i18n/olsontz.cpp: In member function ‘virtual UBool icu_60::OlsonTimeZone::inDaylightTime(UDate, UErrorCode&) const’: ../deps/icu-small/source/i18n/olsontz.cpp:604:18: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized] int32_t raw, dst; diff --git a/test/fixtures/jenkins/git-failure-1/node-test-commit-19225.json b/test/fixtures/jenkins/git-failure-1/node-test-commit-19225.json index 652f4db87..68cff3387 100644 --- a/test/fixtures/jenkins/git-failure-1/node-test-commit-19225.json +++ b/test/fixtures/jenkins/git-failure-1/node-test-commit-19225.json @@ -28,7 +28,7 @@ { "_class": "hudson.model.StringParameterValue", "name": "REBASE_ONTO", - "value": "origin/master" + "value": "origin/main" }, { "_class": "hudson.model.StringParameterValue", diff --git a/test/fixtures/jenkins/git-failure-2/console.txt b/test/fixtures/jenkins/git-failure-2/console.txt index a7be34089..0aedd8aa6 100644 --- a/test/fixtures/jenkins/git-failure-2/console.txt +++ b/test/fixtures/jenkins/git-failure-2/console.txt @@ -29,7 +29,7 @@ 19:15:56 Exporting parameter NODEJS_VERSION with Node.js version '11.0.0' 19:15:56 Exporting parameter NODEJS_MAJOR_VERSION with Node.js major version '11' 19:15:56 [rhel72-s390x] $ /bin/sh -xe /tmp/jenkins7325057057705257195.sh -19:15:56 + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh +19:15:56 + curl https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/node-test-commit-pre.sh 19:15:56 + bash -ex -s before 19:15:56 % Total % Received % Xferd Average Speed Time Time Time Current 19:15:56 Dload Upload Total Spent Left Speed diff --git a/test/fixtures/jenkins/js-flake-1/node-test-commit-19123.json b/test/fixtures/jenkins/js-flake-1/node-test-commit-19123.json index dc078b152..e44cf2f7a 100644 --- a/test/fixtures/jenkins/js-flake-1/node-test-commit-19123.json +++ b/test/fixtures/jenkins/js-flake-1/node-test-commit-19123.json @@ -28,7 +28,7 @@ { "_class": "hudson.model.StringParameterValue", "name": "REBASE_ONTO", - "value": "origin/master" + "value": "origin/main" }, { "_class": "hudson.model.StringParameterValue", diff --git a/test/fixtures/jenkins/js-flake-1/node-test-commit-linux-nodes=debian9-64-19446.txt b/test/fixtures/jenkins/js-flake-1/node-test-commit-linux-nodes=debian9-64-19446.txt index 9331dadef..4fd0d7ca3 100644 --- a/test/fixtures/jenkins/js-flake-1/node-test-commit-linux-nodes=debian9-64-19446.txt +++ b/test/fixtures/jenkins/js-flake-1/node-test-commit-linux-nodes=debian9-64-19446.txt @@ -30,7 +30,7 @@ Exporting parameter NODEJS_VERSION with Node.js version '11.0.0' Exporting parameter NODEJS_MAJOR_VERSION with Node.js major version '11' [debian9-64] $ /bin/sh -xe /tmp/jenkins3291460991233382964.sh + bash -+ curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh ++ curl https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/node-test-commit-pre.sh % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0100 1165 100 1165 0 0 18116 0 --:--:-- --:--:-- --:--:-- 18203 diff --git a/test/fixtures/jenkins/no-compiler-error/node-test-commit-osx-nodes=osx1010-19307.txt b/test/fixtures/jenkins/no-compiler-error/node-test-commit-osx-nodes=osx1010-19307.txt index c34261711..9e18594a9 100644 --- a/test/fixtures/jenkins/no-compiler-error/node-test-commit-osx-nodes=osx1010-19307.txt +++ b/test/fixtures/jenkins/no-compiler-error/node-test-commit-osx-nodes=osx1010-19307.txt @@ -33,7 +33,7 @@ Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10 [osx1010] $ /bin/sh -xe /var/folders/dr/m8hrvy3d71172187rtx7vm380000gp/T/jenkins17599764209366008267.sh -+ curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh ++ curl https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/node-test-commit-pre.sh + bash -ex % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed @@ -76,7 +76,7 @@ Current branch HEAD is up to date, rebase forced. First, rewinding head to replay your work on top of it... Applying: workers,trace_events: set thread name for workers + '[' -n '' ']' -+ curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh ++ curl https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/node-test-commit-diagnostics.sh + bash -ex -s before % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed diff --git a/test/fixtures/jenkins/success/node-test-commit-18960.json b/test/fixtures/jenkins/success/node-test-commit-18960.json index a2dc80b0d..7f2ee499f 100644 --- a/test/fixtures/jenkins/success/node-test-commit-18960.json +++ b/test/fixtures/jenkins/success/node-test-commit-18960.json @@ -28,7 +28,7 @@ { "_class": "hudson.model.StringParameterValue", "name": "REBASE_ONTO", - "value": "origin/master" + "value": "origin/main" }, { "_class": "hudson.model.StringParameterValue", diff --git a/test/fixtures/merged_pr.json b/test/fixtures/merged_pr.json index 06e4da52d..50cd704d6 100644 --- a/test/fixtures/merged_pr.json +++ b/test/fixtures/merged_pr.json @@ -17,7 +17,7 @@ ] }, "title": "lib: awesome changes", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "awesome-changes", "closed": true, "closedAt": "2017-10-28T11:13:43Z", diff --git a/test/fixtures/op_html.json b/test/fixtures/op_html.json index 693703e85..e20453eec 100644 --- a/test/fixtures/op_html.json +++ b/test/fixtures/op_html.json @@ -1,8 +1,8 @@ [ "<p>The npm install rules had a hidden dependency on the <code>node</code> binary<br>\ninstall rule creating the <code>$PREFIX/bin</code> directory.</p>\n<p>Because with <code>./configure --shared</code> no binary is created, the rule<br>\nsubsequently failed. Fix that by creating the directory before<br>\ncreating the symlinks to the npm and npx scripts.</p>\n<p>(Whether it makes sense to install npm without a <code>node</code> binary is<br>\na separate question. This commit is not taking positions. :-))</p>\n<p>Regression introduced in commit <a href=\"https://github.com/nodejs/node/commit/ed8c89a07d159b72a2e351a76c92b8b6a15515bd\" class=\"commit-link\"><tt>ed8c89a</tt></a> (\"build: fix shared installing<br>\ntarget\") which, as the commit log indicates, was itself a bug fix for<br>\nthe <code>./configure --shared</code> install.</p>\n<p>Fixes: <a href=\"https://github.com/nodejs/node/issues/16437\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"267969588\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16437\">#16437</a><br>\nRefs: <a href=\"https://github.com/nodejs/node/pull/15148\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"254809069\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/15148\">#15148</a></p>", - "<p>Refs: <a href=\"https://github.com/nodejs/node/pull/16293\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"266519190\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16293\">#16293</a></p>\n<h5>Checklist</h5>\n\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n<h5>Affected core subsystem(s)</h5>\n\n<p>vm</p>", + "<p>Refs: <a href=\"https://github.com/nodejs/node/pull/16293\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"266519190\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16293\">#16293</a></p>\n<h5>Checklist</h5>\n\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/main/CONTRIBUTING.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n<h5>Affected core subsystem(s)</h5>\n\n<p>vm</p>", "<p>Included reference to \\'constant time\\' in crypto.timingSafeEqual description</p>\n<p><span aria-label=\"This pull request closes issue #16504.\" class=\"issue-keyword tooltipped tooltipped-se\">Fixes</span> : <a href=\"https://github.com/nodejs/node/issues/16504\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"268571876\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16504\">#16504</a></p>", - "<h5 dir=\"auto\">Checklist</h5>\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> documentation is changed or added</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n<h5 dir=\"auto\">Affected core subsystem(s)</h5>\n<p dir=\"auto\">doc, dgram</p>\n<p dir=\"auto\">Refs: <a href=\"https://en.wikipedia.org/w/index.php?title=IPv6_address&type=revision&diff=809494791&oldid=804196124\" rel=\"nofollow\">https://en.wikipedia.org/w/index.php?title=IPv6_address&type=revision&diff=809494791&oldid=804196124</a></p>", + "<h5 dir=\"auto\">Checklist</h5>\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> documentation is changed or added</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/main/CONTRIBUTING.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n<h5 dir=\"auto\">Affected core subsystem(s)</h5>\n<p dir=\"auto\">doc, dgram</p>\n<p dir=\"auto\">Refs: <a href=\"https://en.wikipedia.org/w/index.php?title=IPv6_address&type=revision&diff=809494791&oldid=804196124\" rel=\"nofollow\">https://en.wikipedia.org/w/index.php?title=IPv6_address&type=revision&diff=809494791&oldid=804196124</a></p>", "<h2 dir=\"auto\">v8.5.5 (2022-03-17)</h2>\n<h3 dir=\"auto\">Bug Fixes</h3>\n<ul dir=\"auto\">\n<li><a href=\"https://github.com/npm/cli/commit/0e7511d144bdb6624e4c0fdfb31b4b42ed2954c9\"><code>0e7511d14</code></a> <a href=\"https://github.com/npm/cli/pull/4261\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4261/hovercard\">#4261</a> fix(arborist): _findMissingEdges missing dependency due to inconsistent path separators (<a href=\"https://github.com/salvadorj\">@salvadorj</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/c83069436ef4af75eaef071bc181ba1ab49729e9\"><code>c83069436</code></a> <a href=\"https://github.com/npm/cli/pull/4547\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4547/hovercard\">#4547</a> fix: omit bots from authors (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/f66da2ed8948fbfa919dd5debe52eafe2018735c\"><code>f66da2ed8</code></a> <a href=\"https://github.com/npm/cli/pull/4565\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4565/hovercard\">#4565</a> fix(owner): bypass cache when fetching packument (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/f0c6e86ca5920baa85355af3ea50ed13f7429a10\"><code>f0c6e86ca</code></a> <a href=\"https://github.com/npm/cli/pull/4572\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4572/hovercard\">#4572</a> fix: remove name from unpublished message (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/f7e58fa74d9008731b86c82f75251ca295056cf1\"><code>f7e58fa74</code></a> <a href=\"https://github.com/npm/cli/pull/4572\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4572/hovercard\">#4572</a> fix: remove \"bug the author\" message from package 404 (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/5471ff5fe8f74f46cdc2bb056ba9b496c7dd1a78\"><code>5471ff5fe</code></a> <a href=\"https://github.com/npm/cli/pull/4573\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4573/hovercard\">#4573</a> fix: add isntall alias to install (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/84d19210e5604775a3a413aa32cbba2c103933f2\"><code>84d19210e</code></a> <a href=\"https://github.com/npm/cli/pull/4576\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4576/hovercard\">#4576</a> fix: properly show <code>npm view ./directory</code> (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/e9a2981f55f84ff521ef597883a4e732d08ce1c1\"><code>e9a2981f5</code></a> <a href=\"https://github.com/npm/cli/pull/4578\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4578/hovercard\">#4578</a> fix(arborist): save workspace version (<a href=\"https://github.com/ruyadorno\">@ruyadorno</a>)</li>\n</ul>\n<h3 dir=\"auto\">Documentation</h3>\n<ul dir=\"auto\">\n<li><a href=\"https://github.com/npm/cli/commit/a304052580c070a1f8c1c0cf8cbeec615c46af02\"><code>a30405258</code></a> <a href=\"https://github.com/npm/cli/pull/4580\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4580/hovercard\">#4580</a> docs: add foreground-scripts and ignore-scripts to commands (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/2361a68e14f893e97dad53d66fde32082e23521a\"><code>2361a68e1</code></a> <a href=\"https://github.com/npm/cli/pull/4582\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4582/hovercard\">#4582</a> docs: add isntall alias to install command (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/8ff1dfaaeeb32e88c879b96a786835fe13526a88\"><code>8ff1dfaae</code></a> <a href=\"https://github.com/npm/cli/pull/4575\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4575/hovercard\">#4575</a> docs: explain that linked deps need <code>npm install</code> ran in them (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/ddbb505ec6077576e0a9d00a14b43d32d69e4f9e\"><code>ddbb505ec</code></a> <a href=\"https://github.com/npm/cli/pull/4574\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4574/hovercard\">#4574</a> docs: explain that git-tag-version=false does not commit (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n<li><a href=\"https://github.com/npm/cli/commit/7c878b9781be2e2151f41bd29d46c33e421aeb10\"><code>7c878b978</code></a> <a href=\"https://github.com/npm/cli/pull/4584\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4584/hovercard\">#4584</a> docs: fix unpublish docs to auto generate usage (<a href=\"https://github.com/wraithgar\">@wraithgar</a>)</li>\n</ul>\n<h3 dir=\"auto\">Dependencies</h3>\n<ul dir=\"auto\">\n<li><a href=\"https://github.com/npm/cli/commit/fcc6acfa808aa556748544edf4e9b73262f77608\"><code>fcc6acfa8</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>@npmcli/metavuln-calculator@3.0.1</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/6d3145014861b4198c16d7772d809fd037ece289\"><code>6d3145014</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>pacote@13.0.4</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/f6b771aabece09dca2231426d4f681d3578e5ab7\"><code>f6b771aab</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>make-fetch-happen@10.0.6</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/e26548fb12a3bb23fbe32a336f1305e083aa51c0\"><code>e26548fb1</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>cacache@16.0.0</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/915dda7abeedf79cfe0dde1bd55d80115e2a795d\"><code>915dda7ab</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>init-package-json@3.0.1</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/f2ec2ef1f7a639ea292d6ab442d588ed72198857\"><code>f2ec2ef1f</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>read-package-json@5.0.0</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/340fa51f423a518a96c8015a67d8f6144a2e8051\"><code>340fa51f4</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>pacote@13.0.5</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/9555a5f1d135aa1b8f7374273403efe41e99ee26\"><code>9555a5f1d</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>npm-package-arg@9.0.1</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/b2a494283f45a25d1b87bc40bf2d68812871e89c\"><code>b2a494283</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>normalize-package-data@4.0.0</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/1cb88f4b31019af9cb8eac8a46433b44bba9d061\"><code>1cb88f4b3</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>hosted-git-info@5.0.0</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/f95396a033b75e2a3e9aa83f0b06c527641027a4\"><code>f95396a03</code></a> <a href=\"https://github.com/npm/cli/pull/4562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4562/hovercard\">#4562</a> deps: <code>cacache@16.0.1</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/aec2bfecca4ad3ee7db4481cf068add9c42e7160\"><code>aec2bfecc</code></a> <a href=\"https://github.com/npm/cli/pull/4585\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/npm/cli/pull/4585/hovercard\">#4585</a> deps: <code>cacache@16.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/ed8ab63e4a2c8e6527bf7d49736d1bbb6f0aead2\"><code>ed8ab63e4</code></a> deps: <code>libnpmpack@4.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/0b73bfa82d4eb826ec0dbda4cc457c94580e0d64\"><code>0b73bfa82</code></a> deps: <code>libnpmteam@4.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/475d59b361ef9e260e21d39361baf92f2272f1d7\"><code>475d59b36</code></a> deps: <code>libnpmaccess@6.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/7201c7395f66d3faf24b361e69555490d606ed91\"><code>7201c7395</code></a> deps: <code>libnpmsearch@5.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/f5df358c3af2c23e7818105608bcceabdd8b62fa\"><code>f5df358c3</code></a> deps: <code>libnpmorg@4.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/472e7dd7aa6935cb6b89ec78cbce45f75f3f0044\"><code>472e7dd7a</code></a> deps: <code>libnpmhook@8.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/c901d7290ed09aefe3ba6e8c09cb3126f0d92f95\"><code>c901d7290</code></a> deps: <code>libnpmpublish@6.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/aad53327f23b123d0e017338a9a1b65d40f21efe\"><code>aad53327f</code></a> deps: <code>@npmcli/arborist@5.0.3</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/b40136bcaf32232e4cacdb517ce40f61871da159\"><code>b40136bca</code></a> deps: <code>libnpmdiff@4.0.2</code></li>\n<li><a href=\"https://github.com/npm/cli/commit/5d91201d1c69e3c095a4eedf0f1d702f35b0d8c1\"><code>5d91201d1</code></a> deps: <code>libnpmexec@4.0.2</code></li>\n</ul>", - "<p dir=\"auto\">Original commit from v8 repo:</p>\n<div class=\"snippet-clipboard-content position-relative overflow-auto\" data-snippet-clipboard-copy-content=\"[mac][wasm] Work around MacOS 11.2 code page decommit failures\n\nMacOS 11.2 refuses to set "no access" permissions on memory that\nwe previously used for JIT-compiled code. It is still unclear\nwhether this is WAI on the part of the kernel. In the meantime,\nas a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead\nof mprotect(..., NONE) when discarding code pages. This is inspired\nby what Chromium's gin platform does.\n\nFixed: v8:11389\nChange-Id: I866586932573b4253002436ae5eee4e0411c45fc\nReviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688\nCommit-Queue: Jakob Kummerow <jkummerow@chromium.org>\nCommit-Queue: Michael Lippautz <mlippautz@chromium.org>\nAuto-Submit: Jakob Kummerow <jkummerow@chromium.org>\nReviewed-by: Michael Lippautz <mlippautz@chromium.org>\nCr-Commit-Position: refs/heads/master@{#72559}\"><pre><code>[mac][wasm] Work around MacOS 11.2 code page decommit failures\n\nMacOS 11.2 refuses to set \"no access\" permissions on memory that\nwe previously used for JIT-compiled code. It is still unclear\nwhether this is WAI on the part of the kernel. In the meantime,\nas a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead\nof mprotect(..., NONE) when discarding code pages. This is inspired\nby what Chromium's gin platform does.\n\nFixed: v8:11389\nChange-Id: I866586932573b4253002436ae5eee4e0411c45fc\nReviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688\nCommit-Queue: Jakob Kummerow <jkummerow@chromium.org>\nCommit-Queue: Michael Lippautz <mlippautz@chromium.org>\nAuto-Submit: Jakob Kummerow <jkummerow@chromium.org>\nReviewed-by: Michael Lippautz <mlippautz@chromium.org>\nCr-Commit-Position: refs/heads/master@{#72559}\n</code></pre></div>\n<p dir=\"auto\"><span class=\"issue-keyword tooltipped tooltipped-se\" aria-label=\"This pull request closes issue #37061.\">Fixes</span> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"793190120\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nodejs/node/issues/37061\" data-hovercard-type=\"issue\" data-hovercard-url=\"/nodejs/node/issues/37061/hovercard\" href=\"https://github.com/nodejs/node/issues/37061\">#37061</a><br>\nRef: <a href=\"https://bugs.chromium.org/p/v8/issues/detail?id=11389#c18\" rel=\"nofollow\">https://bugs.chromium.org/p/v8/issues/detail?id=11389#c18</a></p>\n<p dir=\"auto\">For test:</p>\n<ul dir=\"auto\">\n<li>make -j8</li>\n<li>Run the following gist:<br>\n<a href=\"https://gist.githubusercontent.com/targos/8ca8f7a0c76847f29f5658a93c30af1c/raw/adf420ca34e1e0a74c5a70ece059c3d0d2c5c043/crash.js\" rel=\"nofollow\">https://gist.githubusercontent.com/targos/8ca8f7a0c76847f29f5658a93c30af1c/raw/adf420ca34e1e0a74c5a70ece059c3d0d2c5c043/crash.js</a></li>\n</ul>\n<div class=\"highlight highlight-source-shell position-relative overflow-auto\" data-snippet-clipboard-copy-content=\"./node crash.js\n{"exports":[],"reexports":[]}\"><pre>./node crash.js\n{<span class=\"pl-s\"><span class=\"pl-pds\">\"</span>exports<span class=\"pl-pds\">\"</span></span>:[],<span class=\"pl-s\"><span class=\"pl-pds\">\"</span>reexports<span class=\"pl-pds\">\"</span></span>:[]}</pre></div>" + "<p dir=\"auto\">Original commit from v8 repo:</p>\n<div class=\"snippet-clipboard-content position-relative overflow-auto\" data-snippet-clipboard-copy-content=\"[mac][wasm] Work around MacOS 11.2 code page decommit failures\n\nMacOS 11.2 refuses to set "no access" permissions on memory that\nwe previously used for JIT-compiled code. It is still unclear\nwhether this is WAI on the part of the kernel. In the meantime,\nas a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead\nof mprotect(..., NONE) when discarding code pages. This is inspired\nby what Chromium's gin platform does.\n\nFixed: v8:11389\nChange-Id: I866586932573b4253002436ae5eee4e0411c45fc\nReviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688\nCommit-Queue: Jakob Kummerow <jkummerow@chromium.org>\nCommit-Queue: Michael Lippautz <mlippautz@chromium.org>\nAuto-Submit: Jakob Kummerow <jkummerow@chromium.org>\nReviewed-by: Michael Lippautz <mlippautz@chromium.org>\nCr-Commit-Position: refs/heads/main@{#72559}\"><pre><code>[mac][wasm] Work around MacOS 11.2 code page decommit failures\n\nMacOS 11.2 refuses to set \"no access\" permissions on memory that\nwe previously used for JIT-compiled code. It is still unclear\nwhether this is WAI on the part of the kernel. In the meantime,\nas a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead\nof mprotect(..., NONE) when discarding code pages. This is inspired\nby what Chromium's gin platform does.\n\nFixed: v8:11389\nChange-Id: I866586932573b4253002436ae5eee4e0411c45fc\nReviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688\nCommit-Queue: Jakob Kummerow <jkummerow@chromium.org>\nCommit-Queue: Michael Lippautz <mlippautz@chromium.org>\nAuto-Submit: Jakob Kummerow <jkummerow@chromium.org>\nReviewed-by: Michael Lippautz <mlippautz@chromium.org>\nCr-Commit-Position: refs/heads/main@{#72559}\n</code></pre></div>\n<p dir=\"auto\"><span class=\"issue-keyword tooltipped tooltipped-se\" aria-label=\"This pull request closes issue #37061.\">Fixes</span> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"793190120\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nodejs/node/issues/37061\" data-hovercard-type=\"issue\" data-hovercard-url=\"/nodejs/node/issues/37061/hovercard\" href=\"https://github.com/nodejs/node/issues/37061\">#37061</a><br>\nRef: <a href=\"https://bugs.chromium.org/p/v8/issues/detail?id=11389#c18\" rel=\"nofollow\">https://bugs.chromium.org/p/v8/issues/detail?id=11389#c18</a></p>\n<p dir=\"auto\">For test:</p>\n<ul dir=\"auto\">\n<li>make -j8</li>\n<li>Run the following gist:<br>\n<a href=\"https://gist.githubusercontent.com/targos/8ca8f7a0c76847f29f5658a93c30af1c/raw/adf420ca34e1e0a74c5a70ece059c3d0d2c5c043/crash.js\" rel=\"nofollow\">https://gist.githubusercontent.com/targos/8ca8f7a0c76847f29f5658a93c30af1c/raw/adf420ca34e1e0a74c5a70ece059c3d0d2c5c043/crash.js</a></li>\n</ul>\n<div class=\"highlight highlight-source-shell position-relative overflow-auto\" data-snippet-clipboard-copy-content=\"./node crash.js\n{"exports":[],"reexports":[]}\"><pre>./node crash.js\n{<span class=\"pl-s\"><span class=\"pl-pds\">\"</span>exports<span class=\"pl-pds\">\"</span></span>:[],<span class=\"pl-s\"><span class=\"pl-pds\">\"</span>reexports<span class=\"pl-pds\">\"</span></span>:[]}</pre></div>" ] diff --git a/test/fixtures/pr_with_backport.json b/test/fixtures/pr_with_backport.json index fe83adb1f..7ca03541f 100644 --- a/test/fixtures/pr_with_backport.json +++ b/test/fixtures/pr_with_backport.json @@ -7,7 +7,7 @@ "name": "Gabriel Schulhof" }, "url": "https://github.com/nodejs/node/pull/30072", - "bodyHTML": "<p>Build the addons for benchmarks in the same way that the addons for<br>\ntests are built.</p>\n<p>PR-URL: <a class='issue-link js-issue-link' data-error-text='Failed to load issue title' data-id='508006081' data-permission-text='Issue title is private' data-url='https://github.com/nodejs/node/issues/29995' data-hovercard-type='pull_request' data-hovercard-url='/nodejs/node/pull/29995/hovercard' href='https://github.com/nodejs/node/pull/29995'>#29995</a><br>\n<span class='issue-keyword tooltipped tooltipped-se' aria-label='This pull request closes issue #1961.'>Fixes</span>: <a class='ssue-link js-issue-link' data-error-text='Failed to load issue title' data-id='507966018' data-permission-text='Issue title is private' data-url='https://github.com/nodejs/build/issues/1961' data-hovercard-type='issue' data-hovercard-url='/nodejs/build/issues/1961/hovercard' href='https://github.com/nodejs/build/issues/1961'>nodejs/build#1961</a><br>\nRefs: <a class='commit-link' href='https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896'><tt>53ca0b9</tt>#commitcomment-35494896</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/addaleax/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/addaleax'>@addaleax</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/Trott/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/Trott'>@Trott</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/BethGriggs/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/BethGriggs'>@BethGriggs</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/gengjiawen/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/gengjiawen'>@gengjiawen</a></p>\n\n<h5>Checklist</h5>\n\n<ul class='contains-task-list'>\n<li class='task-list-item'><input type='checkbox' id='' disabled='' class='task-list-item-checkbox' checked=''> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class='task-list-item'><input type='checkbox' id='' disabled='' class='task-list-item-checkbox' checked=''> commit message follows <a href='https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines'>commit guidelines</a></li>\n</ul>\n\n<p>We need this PR along with <a class='issue-link js-issue-link' data-error-text='Failed to load issue title' data-id='510938668' data-permission-text='Issue title is private' data-url='https://github.com/nodejs/node/issues/30070' data-hovercard-type='pull_request' data-hovercard-url='/nodejs/node/pull/30070/hovercard' href='https://github.com/nodejs/node/pull/30070'>#30070</a> because <a class='commit-link' href='https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896'><tt>53ca0b9</tt>#commitcomment-35494896</a></p>", + "bodyHTML": "<p>Build the addons for benchmarks in the same way that the addons for<br>\ntests are built.</p>\n<p>PR-URL: <a class='issue-link js-issue-link' data-error-text='Failed to load issue title' data-id='508006081' data-permission-text='Issue title is private' data-url='https://github.com/nodejs/node/issues/29995' data-hovercard-type='pull_request' data-hovercard-url='/nodejs/node/pull/29995/hovercard' href='https://github.com/nodejs/node/pull/29995'>#29995</a><br>\n<span class='issue-keyword tooltipped tooltipped-se' aria-label='This pull request closes issue #1961.'>Fixes</span>: <a class='ssue-link js-issue-link' data-error-text='Failed to load issue title' data-id='507966018' data-permission-text='Issue title is private' data-url='https://github.com/nodejs/build/issues/1961' data-hovercard-type='issue' data-hovercard-url='/nodejs/build/issues/1961/hovercard' href='https://github.com/nodejs/build/issues/1961'>nodejs/build#1961</a><br>\nRefs: <a class='commit-link' href='https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896'><tt>53ca0b9</tt>#commitcomment-35494896</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/addaleax/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/addaleax'>@addaleax</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/Trott/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/Trott'>@Trott</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/BethGriggs/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/BethGriggs'>@BethGriggs</a><br>\nReviewed-By: <a class='user-mention' data-hovercard-type='user' data-hovercard-url='/users/gengjiawen/hovercard' data-octo-click='hovercard-link-click' data-octo-dimensions='link_type:self' href='https://github.com/gengjiawen'>@gengjiawen</a></p>\n\n<h5>Checklist</h5>\n\n<ul class='contains-task-list'>\n<li class='task-list-item'><input type='checkbox' id='' disabled='' class='task-list-item-checkbox' checked=''> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class='task-list-item'><input type='checkbox' id='' disabled='' class='task-list-item-checkbox' checked=''> commit message follows <a href='https://github.com/nodejs/node/blob/main/doc/guides/contributing/pull-requests.md#commit-message-guidelines'>commit guidelines</a></li>\n</ul>\n\n<p>We need this PR along with <a class='issue-link js-issue-link' data-error-text='Failed to load issue title' data-id='510938668' data-permission-text='Issue title is private' data-url='https://github.com/nodejs/node/issues/30070' data-hovercard-type='pull_request' data-hovercard-url='/nodejs/node/pull/30070/hovercard' href='https://github.com/nodejs/node/pull/30070'>#30070</a> because <a class='commit-link' href='https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896'><tt>53ca0b9</tt>#commitcomment-35494896</a></p>", "bodyText": "Build the addons for benchmarks in the same way that the addons for\ntests are built.\nPR-URL: #29995\nFixes: nodejs/build#1961\nRefs: 53ca0b9#commitcomment-35494896\nReviewed-By: @addaleax\nReviewed-By: @Trott\nReviewed-By: @BethGriggs\nReviewed-By: @gengjiawen\n\nChecklist\n\n\n make -j4 test (UNIX), or vcbuild test (Windows) passes\n commit message follows commit guidelines\n\n\nWe need this PR along with #30070 because 53ca0b9#commitcomment-35494896", "labels": { "nodes": [ diff --git a/test/fixtures/pull_requests/doc-only.json b/test/fixtures/pull_requests/doc-only.json index 8f0e42f29..05038429d 100644 --- a/test/fixtures/pull_requests/doc-only.json +++ b/test/fixtures/pull_requests/doc-only.json @@ -7,7 +7,7 @@ "name": "Antoine du Hamel" }, "url": "https://github.com/nodejs/node/pull/34748", - "bodyHTML": "<p>This part of the docs aims to contain documentation regarding package configuration that covers both ESM and CJS realms.</p>\n<p>Refs: <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"670745739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nodejs/modules/issues/539\" data-hovercard-type=\"issue\" data-hovercard-url=\"/nodejs/modules/issues/539/hovercard\" href=\"https://github.com/nodejs/modules/issues/539\">nodejs/modules#539</a></p>\n\n<h5>Checklist</h5>\n\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> documentation is changed or added</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n", + "bodyHTML": "<p>This part of the docs aims to contain documentation regarding package configuration that covers both ESM and CJS realms.</p>\n<p>Refs: <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"670745739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nodejs/modules/issues/539\" data-hovercard-type=\"issue\" data-hovercard-url=\"/nodejs/modules/issues/539/hovercard\" href=\"https://github.com/nodejs/modules/issues/539\">nodejs/modules#539</a></p>\n\n<h5>Checklist</h5>\n\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> documentation is changed or added</li>\n<li class=\"task-list-item\"><input type=\"checkbox\" id=\"\" disabled=\"\" class=\"task-list-item-checkbox\" checked=\"\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/main/doc/guides/contributing/pull-requests.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n", "bodyText": "This part of the docs aims to contain documentation regarding package configuration that covers both ESM and CJS realms.\nRefs: nodejs/modules#539\n\nChecklist\n\n\n make -j4 test (UNIX), or vcbuild test (Windows) passes\n documentation is changed or added\n commit message follows commit guidelines", "labels": { "nodes": [ @@ -39,7 +39,7 @@ ] }, "title": "doc: move package config docs to separate page", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "doc-package-config", "changedFiles": 4, "mergeable": "MERGEABLE", diff --git a/test/fixtures/semver_major_pr.json b/test/fixtures/semver_major_pr.json index a03ae5e57..c5bbe786e 100644 --- a/test/fixtures/semver_major_pr.json +++ b/test/fixtures/semver_major_pr.json @@ -17,6 +17,6 @@ ] }, "title": "lib: awesome changes", - "baseRefName": "master", + "baseRefName": "main", "headRefName": "awesome-changes" } diff --git a/test/unit/pr_summary.test.js b/test/unit/pr_summary.test.js index 59ec78fe4..6d846f2ef 100644 --- a/test/unit/pr_summary.test.js +++ b/test/unit/pr_summary.test.js @@ -42,7 +42,7 @@ describe('PRSummary', () => { ['Author', 'Their Github Account email <pr_author@example.com>' + ' (@pr_author, first-time contributor)'], - ['Branch', 'pr_author:awesome-changes -> nodejs:master'], + ['Branch', 'pr_author:awesome-changes -> nodejs:main'], ['Labels', 'needs-ci, test, doc'], ['Commits', '6'], ['Committers', '3'] @@ -76,7 +76,7 @@ describe('PRSummary', () => { ['Author', 'Their Github Account email <pr_author@example.com>' + ' (@pr_author)'], - ['Branch', 'pr_author:awesome-changes -> nodejs:master'], + ['Branch', 'pr_author:awesome-changes -> nodejs:main'], ['Labels', 'semver-major'], ['Commits', '1'], ['Committers', '1'] @@ -104,7 +104,7 @@ describe('PRSummary', () => { ], table: [ ['Title', 'doc: fix mdn links (#16348)'], - ['Branch', 'pr_author:fix-links -> nodejs:master'], + ['Branch', 'pr_author:fix-links -> nodejs:main'], ['Labels', 'doc'], ['Commits', '1'], ['Committers', '1']