From b2cd216cd3320a43ce8cd794e0d952800f14e53d Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Thu, 23 Jan 2025 22:58:06 +0100
Subject: [PATCH 1/2] refactor: Use boolean props with default value false

Provide `disableSwipe` instead of `allowSwipeNavigation`
(`NcAppContent`) and `enableSwipe` (`NcModal`).

Boolean prop should always - when possible - have a default value of
`false` to allow shorthand prop assignment in the template.
Similar to native HTML boolean attributes:

```vue
<!-- native HTML -->
<button disabled>
<!-- boolean Vue prop with default false -->
<NcModal disable-swipe>
```

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 CHANGELOG.md                                 |  2 +-
 src/components/NcAppContent/NcAppContent.vue | 13 +++++++------
 src/components/NcDialog/NcDialog.vue         |  2 +-
 src/components/NcModal/NcModal.vue           |  8 ++++----
 4 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 33aa0bee9c..c676dc50c9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -134,7 +134,7 @@ Especially the following are now provided as composables:
 * ci: Migrate component tests to Playwright [\#5818](https://github.com/nextcloud-libraries/nextcloud-vue/pull/5818) \([susnux](https://github.com/susnux)\)
 * Change module import paths - drop dist and .js-extension [\#6389](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6389) \([susnux](https://github.com/susnux)\)
 * The plugin was removed - components need to be registered manually now [\#6349](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6349) \([ShGKme](https://github.com/ShGKme)\)
-* chore(Nc*Field): icon slot change note [\#6398](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6398) \([ShGKme](https://github.com/ShGKme)\) 
+* chore(Nc*Field): icon slot change note [\#6398](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6398) \([ShGKme](https://github.com/ShGKme)\)
 * Rename `checked` prop to `modelValue` [\#4994](https://github.com/nextcloud-libraries/nextcloud-vue/pull/4994) \([raimund-schluessler](https://github.com/raimund-schluessler)\)
 * Unify `modelValue` naming [\#4990](https://github.com/nextcloud-libraries/nextcloud-vue/pull/4990) \([raimund-schluessler](https://github.com/raimund-schluessler)\)
 * Remove deprecated mixins [\#4830](https://github.com/nextcloud-libraries/nextcloud-vue/pull/4830) \([raimund-schluessler](https://github.com/raimund-schluessler)\)
diff --git a/src/components/NcAppContent/NcAppContent.vue b/src/components/NcAppContent/NcAppContent.vue
index 0eb1aa4410..8681ef14a8 100644
--- a/src/components/NcAppContent/NcAppContent.vue
+++ b/src/components/NcAppContent/NcAppContent.vue
@@ -67,8 +67,8 @@ The list size must be between the min and the max width value.
 					'app-content-wrapper--show-list': !showDetails,
 					'app-content-wrapper--mobile': isMobile,}">
 				<NcAppDetailsToggle v-if="showDetails" @click.stop.prevent="hideDetails" />
-				<slot v-if="!showDetails" name="list" />
 
+				<slot v-if="!showDetails" name="list" />
 				<slot v-else />
 			</div>
 			<div v-else-if="layout === 'vertical-split' || layout === 'horizontal-split'" class="app-content-wrapper">
@@ -130,11 +130,11 @@ export default {
 	},
 	props: {
 		/**
-		 * Allows to disable the control by swipe of the app navigation open state
+		 * Allows to disable the control by swipe of the app navigation open state.
 		 */
-		allowSwipeNavigation: {
+		disableSwipe: {
 			type: Boolean,
-			default: true,
+			default: false,
 		},
 
 		/**
@@ -175,7 +175,8 @@ export default {
 		},
 
 		/**
-		 * When in mobile view, only the list or the details are shown
+		 * When in mobile view, only the list or the details are shown.
+		 *
 		 * If you provide a list, you need to provide a variable
 		 * that will be set to true by the user when an element of
 		 * the list gets selected. The details will then show a back
@@ -281,7 +282,7 @@ export default {
 	},
 
 	mounted() {
-		if (this.allowSwipeNavigation) {
+		if (!this.disableSwipe) {
 			this.swiping = useSwipe(this.$el, {
 				onSwipeEnd: this.handleSwipe,
 			})
diff --git a/src/components/NcDialog/NcDialog.vue b/src/components/NcDialog/NcDialog.vue
index c129748fd7..5db3d09ea6 100644
--- a/src/components/NcDialog/NcDialog.vue
+++ b/src/components/NcDialog/NcDialog.vue
@@ -209,7 +209,7 @@ export default {
 	<NcModal v-if="open"
 		class="dialog__modal"
 		:enable-slideshow="false"
-		:enable-swipe="false"
+		disable-swipe
 		v-bind="modalProps"
 		@close="handleClosed"
 		@update:show="handleClosing()">
diff --git a/src/components/NcModal/NcModal.vue b/src/components/NcModal/NcModal.vue
index 7f578fc5c3..e0f5e0e4ef 100644
--- a/src/components/NcModal/NcModal.vue
+++ b/src/components/NcModal/NcModal.vue
@@ -410,11 +410,11 @@ export default {
 			default: false,
 		},
 		/**
-		 * Enable swipe between slides
+		 * Disable swipe between slides
 		 */
-		enableSwipe: {
+		disableSwipe: {
 			type: Boolean,
-			default: true,
+			default: false,
 		},
 		spreadNavigation: {
 			type: Boolean,
@@ -731,7 +731,7 @@ export default {
 		 * @param {import('@vueuse/core').SwipeDirection} direction Swipe direction
 		 */
 		handleSwipe(e, direction) {
-			if (this.enableSwipe) {
+			if (!this.disableSwipe) {
 				if (direction === 'left') {
 					// swiping to left to go to the next item
 					this.next(e)

From efd2517b609580f93678bdfd8c9bae8989ab3d84 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Sun, 16 Feb 2025 17:42:23 +0100
Subject: [PATCH 2/2] docs: Document removed props

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 CHANGELOG.md | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c676dc50c9..c0aa91f7f7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -79,6 +79,15 @@ The leading icon slot was changed from `#default` to `#icon` in `Nc*Field` compo
   - `NcTextField`
   - `NcPasswordField`
 
+#### Boolean props default to `false`
+Some boolean props that have been deprecated in favor of alternatives with default value `false`,
+are now removed. Following components have been adjusted:
+
+|     Component | Removed deprecated prop | New alternative |
+|---------------|-------------------------|-----------------|
+|     `NcModal` |           `enableSwipe` |  `disableSwipe` |
+|`NcAppContent` |  `allowSwipeNavigation` | `disabledSwipe` |
+
 #### Mixins are removed
 Mixins only work in Options API and are in general not recommended by Vue anymore: