diff --git a/CHANGELOG.md b/CHANGELOG.md index 33aa0bee9c..c0aa91f7f7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -79,6 +79,15 @@ The leading icon slot was changed from `#default` to `#icon` in `Nc*Field` compo - `NcTextField` - `NcPasswordField` +#### Boolean props default to `false` +Some boolean props that have been deprecated in favor of alternatives with default value `false`, +are now removed. Following components have been adjusted: + +| Component | Removed deprecated prop | New alternative | +|---------------|-------------------------|-----------------| +| `NcModal` | `enableSwipe` | `disableSwipe` | +|`NcAppContent` | `allowSwipeNavigation` | `disabledSwipe` | + #### Mixins are removed Mixins only work in Options API and are in general not recommended by Vue anymore: @@ -134,7 +143,7 @@ Especially the following are now provided as composables: * ci: Migrate component tests to Playwright [\#5818](https://github.com/nextcloud-libraries/nextcloud-vue/pull/5818) \([susnux](https://github.com/susnux)\) * Change module import paths - drop dist and .js-extension [\#6389](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6389) \([susnux](https://github.com/susnux)\) * The plugin was removed - components need to be registered manually now [\#6349](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6349) \([ShGKme](https://github.com/ShGKme)\) -* chore(Nc*Field): icon slot change note [\#6398](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6398) \([ShGKme](https://github.com/ShGKme)\) +* chore(Nc*Field): icon slot change note [\#6398](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6398) \([ShGKme](https://github.com/ShGKme)\) * Rename `checked` prop to `modelValue` [\#4994](https://github.com/nextcloud-libraries/nextcloud-vue/pull/4994) \([raimund-schluessler](https://github.com/raimund-schluessler)\) * Unify `modelValue` naming [\#4990](https://github.com/nextcloud-libraries/nextcloud-vue/pull/4990) \([raimund-schluessler](https://github.com/raimund-schluessler)\) * Remove deprecated mixins [\#4830](https://github.com/nextcloud-libraries/nextcloud-vue/pull/4830) \([raimund-schluessler](https://github.com/raimund-schluessler)\) diff --git a/src/components/NcAppContent/NcAppContent.vue b/src/components/NcAppContent/NcAppContent.vue index 0eb1aa4410..8681ef14a8 100644 --- a/src/components/NcAppContent/NcAppContent.vue +++ b/src/components/NcAppContent/NcAppContent.vue @@ -67,8 +67,8 @@ The list size must be between the min and the max width value. 'app-content-wrapper--show-list': !showDetails, 'app-content-wrapper--mobile': isMobile,}"> - +
@@ -130,11 +130,11 @@ export default { }, props: { /** - * Allows to disable the control by swipe of the app navigation open state + * Allows to disable the control by swipe of the app navigation open state. */ - allowSwipeNavigation: { + disableSwipe: { type: Boolean, - default: true, + default: false, }, /** @@ -175,7 +175,8 @@ export default { }, /** - * When in mobile view, only the list or the details are shown + * When in mobile view, only the list or the details are shown. + * * If you provide a list, you need to provide a variable * that will be set to true by the user when an element of * the list gets selected. The details will then show a back @@ -281,7 +282,7 @@ export default { }, mounted() { - if (this.allowSwipeNavigation) { + if (!this.disableSwipe) { this.swiping = useSwipe(this.$el, { onSwipeEnd: this.handleSwipe, }) diff --git a/src/components/NcDialog/NcDialog.vue b/src/components/NcDialog/NcDialog.vue index c129748fd7..5db3d09ea6 100644 --- a/src/components/NcDialog/NcDialog.vue +++ b/src/components/NcDialog/NcDialog.vue @@ -209,7 +209,7 @@ export default { diff --git a/src/components/NcModal/NcModal.vue b/src/components/NcModal/NcModal.vue index 7f578fc5c3..e0f5e0e4ef 100644 --- a/src/components/NcModal/NcModal.vue +++ b/src/components/NcModal/NcModal.vue @@ -410,11 +410,11 @@ export default { default: false, }, /** - * Enable swipe between slides + * Disable swipe between slides */ - enableSwipe: { + disableSwipe: { type: Boolean, - default: true, + default: false, }, spreadNavigation: { type: Boolean, @@ -731,7 +731,7 @@ export default { * @param {import('@vueuse/core').SwipeDirection} direction Swipe direction */ handleSwipe(e, direction) { - if (this.enableSwipe) { + if (!this.disableSwipe) { if (direction === 'left') { // swiping to left to go to the next item this.next(e)