Skip to content

Commit 7f2b182

Browse files
committed
chore(CI): use Node 20
nodejs/node#52079
1 parent 84ce031 commit 7f2b182

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,23 +21,23 @@ jobs:
2121
- "stable"
2222
- "nightly"
2323
node:
24-
- "16"
24+
- "20"
2525
include:
2626
# only enable coverage on the fastest job
27-
- node: "16"
27+
- node: "20"
2828
ENABLE_CODE_COVERAGE: true
2929

3030
env:
3131
NODE_ENV: test
3232

3333
steps:
3434
- name: Checkout
35-
uses: actions/checkout@v3
35+
uses: actions/checkout@v4
3636
with:
3737
fetch-depth: 2
3838

3939
- name: Setup Node.js ${{ matrix.node }}
40-
uses: actions/setup-node@v3
40+
uses: actions/setup-node@v4
4141
with:
4242
node-version: ${{ matrix.node }}
4343
cache: "npm"

.github/workflows/lint.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ jobs:
1515
runs-on: ubuntu-latest
1616
steps:
1717
- name: Checkout
18-
uses: actions/checkout@v3
18+
uses: actions/checkout@v4
1919

2020
- name: Setup Node.js
21-
uses: actions/setup-node@v3
21+
uses: actions/setup-node@v4
2222
with:
2323
cache: "npm"
2424

src/configuration/shape.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export default class ConfigurationProxy implements IConfigurationShape {
3434
let dir = path.dirname(fsPath)
3535
let formattingOptions = { tabSize: 2, insertSpaces: true }
3636
if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true })
37-
let content = fs.readFileSync(fsPath, { encoding: 'utf8', flag: 'a+' })
37+
let content = fs.readFileSync(fsPath, { flag: 'a+' }).toString('utf8')
3838
content = content || '{}'
3939
let edits = modify(content, [key], value, { formattingOptions })
4040
content = applyEdits(content, edits)

0 commit comments

Comments
 (0)