Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated.modulo (and other AnimatedInterpolation) does not call listener #2513

Closed
1 task done
macrozone opened this issue Apr 21, 2023 · 5 comments
Closed
1 task done
Labels

Comments

@macrozone
Copy link

macrozone commented Apr 21, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Animated.modulo does not call event listeners on update.

This codesandbox shows the issue: https://codesandbox.io/s/vibrant-lumiere-6p71s1?file=/src/App.js

check the logs

the same code does run the listener for both AnimatedValues on react-native, but only the first one on react-native-web.

the same problem exists with Animated.multiply and probably all other AnimatedInterpolations

Expected behavior

Animated.modulo should call addEventListener

Steps to reproduce

see https://codesandbox.io/s/vibrant-lumiere-6p71s1?file=/src/App.js

Test case

https://codesandbox.io/s/vibrant-lumiere-6p71s1?file=/src/App.js

Additional comments

No response

@macrozone macrozone added the bug label Apr 21, 2023
@macrozone macrozone changed the title Animated.modulo does not call event listener Animated.modulo does not call listener Apr 21, 2023
@macrozone macrozone changed the title Animated.modulo does not call listener Animated.modulo (and others) does not call listener Apr 21, 2023
@macrozone macrozone changed the title Animated.modulo (and others) does not call listener Animated.modulo (and other AnimatedInterpolation) does not call listener Apr 21, 2023
@necolas
Copy link
Owner

necolas commented Apr 21, 2023

Yeah it's really annoying to sync modules like Animated, which regularly has bugs and needs patching in RN. See this issue for being able to take on the same version of Animated as is found in RN facebook/react-native#35263

@macrozone
Copy link
Author

Yeah it's really annoying to sync modules like Animated, which regularly has bugs and needs patching in RN. See this issue for being able to take on the same version of Animated as is found in RN facebook/react-native#35263

I see, but I think the Bug may be fixed without the refactorings in react-native first.

I tried to debug it in my project, but did not find yet the culprit.

is there a way to test and try to reproduce it in react-native-web repo directly? Then i would first try to fix it.

@macrozone
Copy link
Author

i checked again, actually the error is already present in react-native itself

@macrozone
Copy link
Author

created an upstream issue facebook/react-native#37061

@necolas
Copy link
Owner

necolas commented Apr 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants