chore: fix info extraction from description and make it optional

Author: MSOB7YY

lib/controller/settings.youtube.dart

@@ -17,6 +17,7 @@ class _YoutubeSettings with SettingsFileWriter {
   final youtubeStyleMiniplayer = true.obs;
   final preferNewComments = false.obs;
   final autoExtractVideoTagsFromInfo = true.obs;
+  final fallbackExtractInfoDescription = true.obs;
   final isAudioOnlyMode = false.obs;
   final rememberAudioOnly = false.obs;
   final topComments = true.obs;
@@ -44,6 +45,7 @@ class _YoutubeSettings with SettingsFileWriter {
     bool? rememberAudioOnly,
     bool? topComments,
     bool? autoExtractVideoTagsFromInfo,
+    bool? fallbackExtractInfoDescription,
     OnYoutubeLinkOpenAction? onYoutubeLinkOpen,
     YTSeekActionMode? tapToSeek,
     YTSeekActionMode? dragToSeek,
@@ -67,6 +69,7 @@ class _YoutubeSettings with SettingsFileWriter {
     if (rememberAudioOnly != null) this.rememberAudioOnly.value = rememberAudioOnly;
     if (topComments != null) this.topComments.value = topComments;
     if (autoExtractVideoTagsFromInfo != null) this.autoExtractVideoTagsFromInfo.value = autoExtractVideoTagsFromInfo;
+    if (fallbackExtractInfoDescription != null) this.fallbackExtractInfoDescription.value = fallbackExtractInfoDescription;
     if (onYoutubeLinkOpen != null) this.onYoutubeLinkOpen.value = onYoutubeLinkOpen;
     if (tapToSeek != null) this.tapToSeek.value = tapToSeek;
     if (dragToSeek != null) this.dragToSeek.value = dragToSeek;
@@ -104,6 +107,7 @@ class _YoutubeSettings with SettingsFileWriter {
       youtubeStyleMiniplayer.value = json['youtubeStyleMiniplayer'] ?? youtubeStyleMiniplayer.value;
       preferNewComments.value = json['preferNewComments'] ?? preferNewComments.value;
       autoExtractVideoTagsFromInfo.value = json['autoExtractVideoTagsFromInfo'] ?? autoExtractVideoTagsFromInfo.value;
+      fallbackExtractInfoDescription.value = json['fallbackExtractInfoDescription'] ?? fallbackExtractInfoDescription.value;
       rememberAudioOnly.value = json['rememberAudioOnly'] ?? rememberAudioOnly.value;
       if (rememberAudioOnly.value) isAudioOnlyMode.value = json['isAudioOnlyMode'] ?? isAudioOnlyMode.value;
       topComments.value = json['topComments'] ?? topComments.value;
@@ -142,6 +146,7 @@ class _YoutubeSettings with SettingsFileWriter {
         'youtubeStyleMiniplayer': youtubeStyleMiniplayer.value,
         'preferNewComments': preferNewComments.value,
         'autoExtractVideoTagsFromInfo': autoExtractVideoTagsFromInfo.value,
+        'fallbackExtractInfoDescription': fallbackExtractInfoDescription.value,
         'isAudioOnlyMode': isAudioOnlyMode.value,
         'rememberAudioOnly': rememberAudioOnly.value,
         'topComments': topComments.value,

lib/ui/widgets/settings/youtube_settings.dart

@@ -608,6 +608,16 @@ class __YTFlagsOptionsState extends State<_YTFlagsOptions> {
               onChanged: (isTrue) => setState(() => settings.youtube.save(markVideoWatched: !isTrue)),
               title: 'mark_video_watched'.toUpperCase(),
             ),
+            CustomSwitchListTile(
+              leading: StackedIcon(
+                baseIcon: Broken.document_text_1,
+                secondaryIcon: Broken.export_1,
+                secondaryIconSize: 12.0,
+              ),
+              value: settings.youtube.fallbackExtractInfoDescription.value,
+              onChanged: (isTrue) => setState(() => settings.youtube.save(fallbackExtractInfoDescription: !isTrue)),
+              title: 'try_extract_tags_info_from_description'.toUpperCase(),
+            ),
             CustomListTile(
               icon: Broken.cpu,
               title: 'innertube_client'.toUpperCase(),

lib/youtube/controller/yt_filename_rebuilder.dart

@@ -5,6 +5,8 @@ class _YtFilenameRebuilder {
 
   final paramRegex = RegExp(r'%\((\w+)\)s');
 
+  bool get fallbackExtractInfoFromDescription => settings.youtube.fallbackExtractInfoDescription.value;
+
   String? rebuildFilenameWithDecodedParams(
     String filenameEncoded,
     String videoId,
@@ -109,8 +111,10 @@ class _YtFilenameRebuilder {
           final fulltitle = pageResult?.videoInfo?.title ?? videoItem?.title ?? streams?.info?.title;
           final splitted = fulltitle?.splitArtistAndTitle();
 
-          final possibleExtracted = _extractArtistTitleFromDescriptionIfNecessary(splitted, (infos) => infos.$2?.keepFeatKeywordsOnly(), streams, pageResult, videoItem);
-          if (possibleExtracted != null) return possibleExtracted;
+          if (fallbackExtractInfoFromDescription) {
+            final possibleExtracted = _extractArtistTitleFromDescriptionIfNecessary(splitted, (infos) => infos.$2?.keepFeatKeywordsOnly(), streams, pageResult, videoItem);
+            if (possibleExtracted != null) return possibleExtracted;
+          }
 
           return splitted?.$2?.keepFeatKeywordsOnly() ?? streams?.info?.title ?? fulltitle;
         }(),
@@ -120,8 +124,10 @@ class _YtFilenameRebuilder {
 
           if (fulltitle != null) {
             final splitted = fulltitle.splitArtistAndTitle();
-            final possibleExtracted = _extractArtistTitleFromDescriptionIfNecessary(splitted, (infos) => infos.$1, streams, pageResult, videoItem);
-            if (possibleExtracted != null) return possibleExtracted;
+            if (fallbackExtractInfoFromDescription) {
+              final possibleExtracted = _extractArtistTitleFromDescriptionIfNecessary(splitted, (infos) => infos.$1, streams, pageResult, videoItem);
+              if (possibleExtracted != null) return possibleExtracted;
+            }
             final String? artist = splitted.$1;
             if (artist != null) return artist;
           } else {
@@ -203,10 +209,11 @@ class _YtFilenameRebuilder {
       final description = _getDescription(streams, pageResult, videoItem);
       if (description != null) {
         final title = info?.$2?.splitFirst('(').splitFirst('[');
-        final regex = title == null ? RegExp('(song|info|details)\\W+(.+)', caseSensitive: false) : RegExp('(song|info|details)?\\W+(.+$title.+)', caseSensitive: false);
+        final regex = title == null ? RegExp('^\\W*(song|info|details)(.*)', caseSensitive: false) : RegExp('^\\W*(song|info|details)?(.*$title.*)', caseSensitive: false);
         final regexArtist = RegExp('artist:(.*)', caseSensitive: false);
         final regexTitle = RegExp('title:(.*)', caseSensitive: false);
-        for (final line in description.split('\n')) {
+        for (String line in description.split('\n')) {
+          line = line.replaceFirst(RegExp('Nightcore\\W*', caseSensitive: false), '');
           final m = regex.firstMatch(line);
           try {
             var infosLine = m?.group(2)?.splitArtistAndTitle();

pubspec.yaml

@@ -1,7 +1,7 @@
 name: namida
 description: A Beautiful and Feature-rich Music Player, With YouTube & Video Support Built in Flutter
 publish_to: "none"
-version: 4.6.47-beta+241103030
+version: 4.6.48-beta+241103030
 
 environment:
   sdk: ">=3.4.0 <4.0.0"