Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move breakpointsComputed set to better place #1064

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Jan 28, 2025

setBreakpoints is called in 2 places now so this block should live in that function

@luwes luwes self-assigned this Jan 28, 2025
@luwes luwes requested review from heff and a team as code owners January 28, 2025 19:23
Copy link

vercel bot commented Jan 28, 2025

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:25pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:25pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:25pm

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (3ea80df) to head (8925249).
Report is 150 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   78.55%   77.49%   -1.07%     
==========================================
  Files          59       51       -8     
  Lines       11080    12325    +1245     
  Branches        0      723     +723     
==========================================
+ Hits         8704     9551     +847     
- Misses       2376     2746     +370     
- Partials        0       28      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes merged commit 43c58e8 into muxinc:main Jan 28, 2025
7 of 8 checks passed
@luwes luwes deleted the breakpoints-prop branch January 28, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants