Skip to content

Commit d0a27c1

Browse files
authoredOct 18, 2021
chore(v2): minimum supported node version is now v14 (aws#17036)
This is the current active LTS version and is a good minimum requirement. Re-introduction of aws#11964. Fixes aws#16438 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 30f4584 commit d0a27c1

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed
 

‎.yarnrc

+1
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@
77
# be forced to registry.yarnpkg.com.
88
# https://github.com/npm/cli/issues/3783
99
registry "https://registry.npmjs.org"
10+
ignore-engines true # the 'engines' key for 'aws-cdk-lib' has specifies node14 as min while v1 will remain at node10

‎tools/@aws-cdk/pkglint/lib/rules.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -1129,7 +1129,11 @@ export class MustHaveNodeEnginesDeclaration extends ValidationRule {
11291129
public readonly name = 'package-info/engines';
11301130

11311131
public validate(pkg: PackageJson): void {
1132-
expectJSON(this.name, pkg, 'engines.node', '>= 10.13.0 <13 || >=13.7.0');
1132+
if (cdkMajorVersion() === 2) {
1133+
expectJSON(this.name, pkg, 'engines.node', '>= 14.15.0');
1134+
} else {
1135+
expectJSON(this.name, pkg, 'engines.node', '>= 10.13.0 <13 || >=13.7.0');
1136+
}
11331137
}
11341138
}
11351139

0 commit comments

Comments
 (0)