Merge pull request #169 from mozilla/clippy-to-string

Victor Porof · web-flow · commit 346fe34e2f5e · 2019-11-13T07:29:28.000+01:00
Fix clippy `inefficient_to_string` warnings on string values
diff --git a/src/value.rs b/src/value.rs
@@ -208,8 +208,8 @@ impl<'s> From<&'s Value<'s>> for OwnedValue {
             Value::F64(v) => OwnedValue::F64(**v),
             Value::Instant(v) => OwnedValue::Instant(*v),
             Value::Uuid(v) => OwnedValue::Uuid(Uuid::from_bytes(**v)),
-            Value::Str(v) => OwnedValue::Str(v.to_string()),
-            Value::Json(v) => OwnedValue::Json(v.to_string()),
+            Value::Str(v) => OwnedValue::Str((*v).to_string()),
+            Value::Json(v) => OwnedValue::Json((*v).to_string()),
             Value::Blob(v) => OwnedValue::Blob(v.to_vec()),
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -208,8 +208,8 @@ impl<'s> From<&'s Value<'s>> for OwnedValue {`
`208`	`208`	`Value::F64(v) => OwnedValue::F64(**v),`
`209`	`209`	`Value::Instant(v) => OwnedValue::Instant(*v),`
`210`	`210`	`Value::Uuid(v) => OwnedValue::Uuid(Uuid::from_bytes(**v)),`
`211`		`- Value::Str(v) => OwnedValue::Str(v.to_string()),`
`212`		`- Value::Json(v) => OwnedValue::Json(v.to_string()),`
	`211`	`+ Value::Str(v) => OwnedValue::Str((*v).to_string()),`
	`212`	`+ Value::Json(v) => OwnedValue::Json((*v).to_string()),`
`213`	`213`	`Value::Blob(v) => OwnedValue::Blob(v.to_vec()),`
`214`	`214`	`}`
`215`	`215`	`}`