Skip to content

Commit 444efdb

Browse files
johanneswuerbachsatazor
authored andcommittedNov 4, 2016
Fix shell option with Node 7 (#48)
Node versions >= 6 are supporting the shell option. Also added Node 7 to CI.
1 parent 8deb123 commit 444efdb

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed
 

‎.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ node_js:
44
- '0.12'
55
- '4'
66
- '6'
7+
- '7'

‎appveyor.yml

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ environment:
1515
- nodejs_version: 0.12
1616
- nodejs_version: 4
1717
- nodejs_version: 6
18+
- nodejs_version: 7
1819

1920
# get the latest stable version of Node 0.STABLE.latest
2021
install:

‎lib/parse.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ var readShebang = require('./util/readShebang');
88

99
var isWin = process.platform === 'win32';
1010
var skipShellRegExp = /\.(?:com|exe)$/i;
11-
var supportsShellOption = parseInt(process.version.substr(1).split('.')[0], 10) === 6;
11+
var supportsShellOption = parseInt(process.version.substr(1).split('.')[0], 10) >= 6;
1212

1313
function parseNonShell(parsed) {
1414
var shebang;

‎test/test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ extension\');', { mode: parseInt('0777', 8) });
486486
});
487487
});
488488
} else {
489-
it.only('should use nodejs\' spawn when option.shell is specified', function (next) {
489+
it('should use nodejs\' spawn when option.shell is specified', function (next) {
490490
buffered(method, 'echo', ['hello &&', 'echo there'], { shell: true }, function (err, data, code) {
491491
expect(err).to.not.be.ok();
492492
expect(code).to.be(0);

0 commit comments

Comments
 (0)
Please sign in to comment.