Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚗 Static style extraction performance boost #2

Open
natew opened this issue Jan 6, 2017 · 0 comments
Open

🚗 Static style extraction performance boost #2

natew opened this issue Jan 6, 2017 · 0 comments
Assignees
@natew

Comments

@natew
Copy link
Contributor

natew commented Jan 6, 2017

We do quite a bit in fancyElement right now, which probably degrades performance quite a bit. It isn't super noticeable on our current app, but this would definitely be a big win in CPU cycles.

We did this already in Flint a while back but steps would be:

  • Have babel tag each file where decorator is used with a UID
  • Loop over static style and static theme objects and hoist static stuff above
  • Register that stuff with gloss at runtime
  • Redo fancyElement to look for those statics at runtime and use them
@natew natew self-assigned this Jan 6, 2017
@natew natew changed the title 🚗 Static style extraction performance boost 🚗 Static style extraction performance boost Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natew natew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natew