fix(ChangeStream): whitelist resumable errors #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes which errors are considered resumable on change streams,
adding support for the new ResumableChangeStreamError label.
- Removes ElectionInProgress (216) from ResumableChangeStreamError.
- Updates ChangeStream prose tests which described startAfter
behavior for unsupported server versions.
- Fixes use of startAfter/resumeAfter when resuming from an
invalidate event. Implement prose tests #17 and #18.
NODE-2478
NODE-2522
The isResumableError function should not check for the NonResumableChangeStreamError label. NODE-2565
mbroadst
approved these changes
Apr 30, 2020
|
@emadum please make sure to update the ticket to indicate that this was fixed in 3.5.8 instead of 3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging resumable error whitelist related changes from
3.6- the goal is to rebase #2333 off these changes once merged into3.5.NODE-2478
NODE-2522
NODE-2565
What changed?
Are there any files to ignore?