Skip to content

add spi mechanism for VersionHelper #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

XenoAmess
Copy link
Contributor

@XenoAmess XenoAmess commented Jul 4, 2022

add spi mechanism for VersionHelper

close #606

@slawekjaranowski
Copy link
Member

Thanks for proposition.

I would do more refactor for such feature

  • separate module for api - in order to allow extension to depends only on simple api not on whole plugin implementation
  • update plugin dependency to newer Maven api, eg 3.2.5
  • use JSR-330 to provide plugin components

of course step by step

@slawekjaranowski
Copy link
Member

By the way we should add IT test for such feature and documentation with simple example.

@XenoAmess
Copy link
Contributor Author

XenoAmess commented Jul 4, 2022

Thanks for proposition.

I would do more refactor for such feature

  • separate module for api - in order to allow extension to depends only on simple api not on whole plugin implementation
  • update plugin dependency to newer Maven api, eg 3.2.5
  • use JSR-330 to provide plugin components

of course step by step

That would be a very large refactor...
At least this project would be split to a multi model maven repo.
Too large that I'm just afraid you would'n review it.

@slawekjaranowski
Copy link
Member

That would be a very large refactor...
At least this project would be split to a multi model maven repo.
Too large that I'm just afraid you would'n review it.

I know that can be a big refactor. 😄

@XenoAmess XenoAmess force-pushed the add_spi_mechanism_for_VersionHelper branch from 9431771 to adc45b3 Compare July 14, 2022 20:40
@XenoAmess
Copy link
Contributor Author

XenoAmess commented Jul 14, 2022

That would be a very large refactor...
At least this project would be split to a multi model maven repo.
Too large that I'm just afraid you would'n review it.

I know that can be a big refactor. 😄

big refactor done! please have a look!
@slawekjaranowski

@slawekjaranowski
Copy link
Member

great - big thanks,
can you do refactoring in separate PR? - only split by module without other changes.

@github-actions
Copy link

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Aug 21, 2023
@github-actions github-actions bot closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add spi mechanism for version update,compare etc?
2 participants