Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-runner-junit-reporter): Add support for flat test files to junit-reporter #2904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JackRobards
Copy link

What I did

Add support for test files that do not use a describe block (aka "flat") to the junit-reporter.

A file like this would now be included in the report, where before it would not:

it('under addition', function () {
  chai.expect(1 + 1).to.equal(2);
});

it('null hypothesis', function () {
  chai.expect(true).to.be.true;
});

it('asserts error', function () {
  chai.expect(false).to.be.true;
});

As for what to call the Test Suite - I followed the same pattern that the toResultsWithMetadataByBrowserTestFileName function was using. So each of these test suites will be named based on the browser + file being tested.

This should be a non-breaking change from my testing - it is only intended to detect some test cases that wouldn't be included previously!

closes #2901

Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 6d6ee2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-junit-reporter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-runner-junit-reporter] JUnit reporter does not detect tests outside of "describe" suites
1 participant