fix: add Mocha to global variable #4401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
To apply UMD pattern, Mocha module was located in
mocha
as module name. But browsers are be able to access Mocha as global variable with this change.I added rollup config
footer
to assign Mocha module to global variable. I hope that this would be the alias to acutal Mocha module, not deep cloning another Mocha.Alternate Designs
in
browser-entry.js
from line213
I would like to suggest like next
OR,
anyway, I was afraid of any side-effects and then I selected this version as PR.
Benefits
Possible Drawbacks
There would be duplicated Mocha modules on browser.
IMHO, an alias for this module would be better than assign object but I would like to avoid to modify core code.
Applicable issues
#4395
Versioning Info