-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn deprecation warnings into errors #585
Comments
I think it's probably a good idea to add deprecation warnings to anything where it's a somewhat one to one change with functions, and then the rest of the things could be in a nice comprehensive list or something that we can post on the website/docs. |
In terms of indexing into a simulation index with square brackets, I have completely removed that |
If nobody is using it, the deprecation does no harm. If they are using it and you don't deprecate, it causes grief. Any reason to not deprecate? Seems like the better choice to me! |
Agreed, no reason not to deprecate except laziness, I'll go grab that old PR and add back in a deprecated |
Steps:
@deprecate
orBase.depwarn
MethodException
since methods will be removed. This will require cleaning out the deprecated code, any helper functions for deprecation warnings, and any tests of the now removed code.Deprecations include the following (also search for
Base.depwarn
and@deprecate
)TimestepArray
at the time index position withgetindex
orsetindex!
is_time
oris_timestep
set_param!
marginal
tomodified
inMarginalModel
'sreplace_comp!
toreplace!
w/ julia argument convention (use pair)The text was updated successfully, but these errors were encountered: