Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get composite version of DICE working #575

Closed
corakingdon opened this issue Oct 11, 2019 · 3 comments
Closed

Get composite version of DICE working #575

corakingdon opened this issue Oct 11, 2019 · 3 comments
Assignees
Milestone

Comments

@corakingdon
Copy link
Collaborator

corakingdon commented Oct 11, 2019

Branch composite on MimiDICE2010 here: https://github.com/anthofflab/MimiDICE2010.jl/tree/composite

@corakingdon corakingdon added this to the v1.1.0 milestone Oct 11, 2019
@corakingdon
Copy link
Collaborator Author

corakingdon commented Oct 11, 2019

Try

pkg> add MimiDICE2010#composite
m = MimiDICE2010.get_model_composite()
run(m)

@corakingdon corakingdon modified the milestones: v1.1.0, v1.0.0 Feb 5, 2020
@corakingdon corakingdon assigned corakingdon and unassigned rjplevin Apr 11, 2020
@corakingdon
Copy link
Collaborator Author

This works now, but I want to wait until there are better datum access methods for composites and then add a validation test file for this composite version. We should also decide what we want our convention to be for model packages going forward: do we want get_model to return the composite version or the flat version? Do we want a keyword argument for which kind it should return, or a separate function?

@corakingdon
Copy link
Collaborator Author

update: Lisa has added validation testing to the composite version, now we just need to decide what we want our convention to be for a "get_model_composite" function, or if we should release new versions of the model packages where the composite version is the main version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants