Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable first/last keywords #567

Closed
corakingdon opened this issue Oct 7, 2019 · 3 comments
Closed

Disable first/last keywords #567

corakingdon opened this issue Oct 7, 2019 · 3 comments
Assignees
Milestone

Comments

@corakingdon
Copy link
Collaborator

Currently on master you can't have components of different time lengths. The use of first and last keywords in add_comp! was disabled in order to get composite components working. I think before v1.0.0 we should decide if we are going to try to get this working, or if not, then I think we should remove the keywords from the add_comp! function all together.

@corakingdon corakingdon added this to the v1.0.0 milestone Oct 7, 2019
@corakingdon
Copy link
Collaborator Author

If we won't allow this, then I think there are also some getindex functions we could remove, that were implemented for the case where the TIMES of the timestep don't match the TIMES of the timestep array, which would no longer be needed

@davidanthoff davidanthoff changed the title decide whether or not to allow first/last keywords Disable first/last keywords Oct 11, 2019
@davidanthoff
Copy link
Collaborator

For now disable last and first keyword for 1.0.0.

@corakingdon
Copy link
Collaborator Author

delete keywords from add_comp function, and remove from documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants