Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The various functions for the MCS API shouldn't use camelCasing #559

Closed
davidanthoff opened this issue Oct 1, 2019 · 1 comment
Closed

The various functions for the MCS API shouldn't use camelCasing #559

davidanthoff opened this issue Oct 1, 2019 · 1 comment
Assignees
@corakingdon
Labels
enhancement
Milestone
v0.10.0

Comments

@davidanthoff
Copy link
Collaborator

camelCasing is only used for types in Julia (one of the few clear style rules :) ), so we shouldn't use it for things like deleteSave! etc. I think underscores would be the right style? So delete_save!, I assume.
@corakingdon corakingdon self-assigned this Oct 1, 2019
@corakingdon
Copy link
Collaborator

corakingdon commented Oct 1, 2019 •
edited
Loading

Agreed, I can do this after we merge #556

@corakingdon corakingdon added this to the v1.0.0 milestone Oct 4, 2019
@corakingdon corakingdon mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corakingdon corakingdon

Labels
enhancement
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@davidanthoff @corakingdon