setindex! in TimestepArrays with Colon doesn't work

[corakingdon]

I think the following is an internal bug. We have implemented setindex! functions for TimestepArrays with AnyIndex (line 268 in "src/core/time.jl" for vectors), but it appears that function is not getting used in the following code, and the values fail to be set. (I haven't tried out the debugger yet to be able to step through and see what function is actually being called in the second line)

julia> x=Mimi.TimestepVector{Mimi.FixedTimestep{2005,10}, Float64}(zeros(10))
Mimi.TimestepArray{Mimi.FixedTimestep{2005,10,LAST} where LAST,Float64,1}([0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0])

julia> x[:].=1
10-element Array{Float64,1}:
 1.0
 1.0
 1.0
 1.0
 1.0
 1.0
 1.0
 1.0
 1.0
 1.0

julia> x
Mimi.TimestepArray{Mimi.FixedTimestep{2005,10,LAST} where LAST,Float64,1}([0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0])

[rjplevin]

It appears that broadcasting .= doesn't result in calling setindex! as one would expect. I've been looking for the right method to override, but I haven't found it yet. I'm hoping @davidanthoff has run into this before.

I edited this after re-running the debugger. Stepping line by line did reveal that unsafe_copyto! is being called...

[rjplevin]

I believe the answer is here, though it's buried pretty deep... still looking.

[rjplevin]

The magic sauce:

Base.dotview(v::Mimi.TimestepArray, args...) = Base.dotview(v.data, args...).

[corakingdon]

amazing! thank you!

[corakingdon]

#472