Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak autoClosingPairs to make JavaScript docblock insertion less intrusive #51131

Closed
kAlvaro opened this issue Jun 5, 2018 · 2 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-contrib Editor collection of extras feature-request Request for new features or functionality

Comments

@kAlvaro
Copy link

kAlvaro commented Jun 5, 2018

As soon as you type /** you immediately get /**𝖨 */ (where 𝖨 is the cursor). If you didn't intend to start a docblock you need to remove the extraneous */. I'd appreciate two enhancements:

  • Expand to docblock only after /**<space> or /**<enter>.
  • Disable the overall feature if you're already inside a comment and maybe if the line already has code before the caret. (Other invalid contexts seem to be detected nicely.)

This is a follow-up to #51047.

@vscodebot
Copy link

vscodebot bot commented Jun 5, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jun 5, 2018
@mjbvz mjbvz added the feature-request Request for new features or functionality label Jun 20, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 25, 2018

Duplicate of #1966

@mjbvz mjbvz marked this as a duplicate of #1966 Jun 25, 2018
@mjbvz mjbvz closed this as completed Jun 25, 2018
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-contrib Editor collection of extras feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants