Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak autoClosingPairs to make PHP docblock insertion less intrusive #51130

Closed
kAlvaro opened this issue Jun 5, 2018 · 2 comments
Closed

Tweak autoClosingPairs to make PHP docblock insertion less intrusive #51130

kAlvaro opened this issue Jun 5, 2018 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code php PHP support issues

Comments

@kAlvaro
Copy link

kAlvaro commented Jun 5, 2018

As soon as you type /** you immediately get /**𝖨 */ (where 𝖨 is the cursor). If you didn't intend to start a docblock you need to remove the extraneous */. I'd appreciate two enhancements:

  • Expand to docblock only after /**<space> or /**<enter>.
  • Disable the overall feature if you're already inside a comment and maybe if the line already has code before the caret. (Other invalid contexts seem to be detected nicely.)

This is a follow-up to #51047.

@vscodebot
Copy link

vscodebot bot commented Jun 5, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jun 5, 2018
@roblourens roblourens added feature-request Request for new features or functionality php PHP support issues and removed editor editor-contrib Editor collection of extras labels Sep 13, 2018
@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
@roblourens
Copy link
Member

This matches js/ts and other languages, we don't have the ability to do more, but there are open requests to extend the basic feature such as #1966

@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Oct 14, 2021
@roblourens roblourens removed this from the Backlog milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code php PHP support issues
Projects
None yet
Development

No branches or pull requests

2 participants