Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] Add an option to collapse import declarations by defaults #128809

Closed
Kingwl opened this issue Jul 16, 2021 · 1 comment · Fixed by #128978
Closed

[folding] Add an option to collapse import declarations by defaults #128809

Kingwl opened this issue Jul 16, 2021 · 1 comment · Fixed by #128978
Assignees
@aeschli
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
July 2021

Comments

@Kingwl
Copy link
Contributor

Kingwl commented Jul 16, 2021 •
edited
Loading

Might needs microsoft/TypeScript#45062
@Kingwl Kingwl changed the title Add a preference to collapse import declaration by defaults Add an option to collapse import declaration by defaults Jul 16, 2021
@Kingwl Kingwl changed the title Add an option to collapse import declaration by defaults Add an option to collapse import declarations by defaults Jul 16, 2021
@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 19, 2021

We are already have FoldingRangeKind.Imports.

It's might not a ts only feature. I suppose It should be a editor support for all folding range if it's marked as imports.

@Kingwl Kingwl mentioned this issue Jul 19, 2021
Merged
@aeschli aeschli assigned aeschli and unassigned mjbvz Jul 19, 2021
@aeschli aeschli added editor-folding Editor code folding issues feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Jul 19, 2021
@aeschli aeschli added this to the July 2021 milestone Jul 19, 2021
@aeschli aeschli changed the title Add an option to collapse import declarations by defaults [folding] Add an option to collapse import declarations by defaults Jul 19, 2021
This was referenced Jul 19, 2021
Open
Closed
@aeschli aeschli added on-testplan and removed verification-needed Verification of issue is requested labels Jul 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
July 2021
Development

Successfully merging a pull request may close this issue.

Add auto folding for imports spans Kingwl/vscode
4 participants
@aeschli @Kingwl @mjbvz and others