Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color routine skip the function name token for SQL string's #103506

Closed
ghost opened this issue Jul 28, 2020 · 3 comments
Closed

Color routine skip the function name token for SQL string's #103506

ghost opened this issue Jul 28, 2020 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@ghost
Copy link

ghost commented Jul 28, 2020

Issue Type: Bug.
VS Code version: Code 1.47.2 (17299e4, 2020-07-15T18:22:06.216Z)
Insider: No.
OS version: Windows_NT x64 10.0.18363

It's not a big deal!, but it's seem the color routine skip the function name token for SQL string
"SELECT ... '" . myfunction() ." ... "
while it's working fine for regular string (without SELECT).

color_bug

See the screenshot.
Thank you,

@bpasero bpasero added the languages-basic Basic language support issues label Aug 21, 2020
@alexr00
Copy link
Member

alexr00 commented Aug 27, 2020

Can you please provide a full copy/pastable example where the issue happens?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Aug 27, 2020
@ghost
Copy link
Author

ghost commented Aug 27, 2020

Just like the screenshot

test.php

<?php
echo " ... '". foo() ."' ...";
echo " SELECT ... '". foo() ."' ...";
?>

I'm using color theme Dark+ (default dark)

@alexr00
Copy link
Member

alexr00 commented Aug 31, 2020

Thanks for the example. It looks like the SQL scope is leaking.

image

I think this is a duplicate of atom/language-php#336

@alexr00 alexr00 closed this as completed Aug 31, 2020
@alexr00 alexr00 added *duplicate Issue identified as a duplicate of another issue(s) grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream and removed languages-basic Basic language support issues info-needed Issue requires more information from poster labels Aug 31, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

2 participants