Adding silent-mode option to command line args parser (#1060)

Co-authored-by: Vasileios Zois <[email protected]>

Author: TalZaccai

libs/host/GarnetServer.cs

@@ -97,7 +97,7 @@ public GarnetServer(string[] commandLineArgs, ILoggerFactory loggerFactory = nul
                 this.initLogger = (MemoryLogger)memLogProvider.CreateLogger("ArgParser");
             }
 
-            if (!ServerSettingsManager.TryParseCommandLineArguments(commandLineArgs, out var serverSettings, out _, out var exitGracefully, this.initLogger))
+            if (!ServerSettingsManager.TryParseCommandLineArguments(commandLineArgs, out var serverSettings, out _, out var exitGracefully, logger: this.initLogger))
             {
                 if (exitGracefully)
                     Environment.Exit(0);

libs/host/ServerSettingsManager.cs

@@ -29,12 +29,13 @@ internal static class ServerSettingsManager
         /// then overridden by any options specified in the command line arguments (if any).
         /// </summary>
         /// <param name="args">Command line arguments</param>
-        /// <param name="logger">Logger</param>
         /// <param name="options">Options object containing parsed configuration settings</param>
         /// <param name="invalidOptions">List of Options properties that did not pass validation</param>
         /// <param name="exitGracefully">True if should exit gracefully when parse is unsuccessful</param>
+        /// <param name="silentMode">If true, help text will not be printed to console when parse is unsuccessful</param>
+        /// <param name="logger">Logger</param>
         /// <returns>True if parsing succeeded</returns>
-        internal static bool TryParseCommandLineArguments(string[] args, out Options options, out List<string> invalidOptions, out bool exitGracefully, ILogger logger = null)
+        internal static bool TryParseCommandLineArguments(string[] args, out Options options, out List<string> invalidOptions, out bool exitGracefully, bool silentMode = false, ILogger logger = null)
         {
             options = null;
             invalidOptions = [];
@@ -63,7 +64,7 @@ internal static bool TryParseCommandLineArguments(string[] args, out Options opt
 
             var consolidatedArgs = ConsolidateFlagArguments(args);
             // Parse command line arguments
-            if (!parser.TryParseArguments<Options>(consolidatedArgs, argNameToDefaultValue, out var cmdLineOptions, out exitGracefully))
+            if (!parser.TryParseArguments<Options>(consolidatedArgs, argNameToDefaultValue, out var cmdLineOptions, out exitGracefully, silentMode: silentMode))
                 return false;
 
             // Check if any arguments were not parsed
@@ -114,7 +115,7 @@ internal static bool TryParseCommandLineArguments(string[] args, out Options opt
 
             // Re-parse command line arguments after initializing Options object with initialization function
             // In order to override options specified in the command line arguments
-            if (!parser.TryParseArguments(consolidatedArgs, argNameToDefaultValue, out options, out exitGracefully, () => initOptions))
+            if (!parser.TryParseArguments(consolidatedArgs, argNameToDefaultValue, out options, out exitGracefully, () => initOptions, silentMode))
                 return false;
 
             // Validate options
@@ -175,15 +176,19 @@ private static Dictionary<string, object> GetArgumentNameToValue(Options options
         /// <param name="obj">Parsed object, default(T) if parse unsuccessful</param>
         /// <param name="exitGracefully">True if should exit gracefully when parse is unsuccessful</param>
         /// <param name="factory">Optional T factory for object initialization</param>
+        /// <param name="silentMode">If true, help messages will not be printed to console.</param>
         /// <returns>True if parse successful</returns>
-        private static bool TryParseArguments<T>(this Parser parser, string[] args, IDictionary<string, object> argNameToDefaultValue, out T obj, out bool exitGracefully, Func<T> factory = null) where T : new()
+        private static bool TryParseArguments<T>(this Parser parser, string[] args, IDictionary<string, object> argNameToDefaultValue, out T obj, out bool exitGracefully, Func<T> factory = null, bool silentMode = false) where T : new()
         {
             var result = parser.ParseArguments(factory ?? (() => new T()), args);
             var tmpExitGracefully = true;
 
             obj = result.MapResult(parsed => parsed,
                 notParsed =>
                 {
+                    if (silentMode)
+                        return default;
+
                     var errors = notParsed.ToList();
                     if (errors.IsVersion()) // Check if error is version request
                     {