refactor/promise (#176)

* refactor(promise): rewrite promise

* refactor(promise): rewrite queue

* chore: resolve conflicts

Author: mg901

bun.lockb

@@ -16,7 +16,7 @@
   },
   "devDependencies": {
     "@commitlint/cli": "^18.6.1",
-    "@commitlint/config-conventional": "^19.5.0",
+    "@commitlint/config-conventional": "^19.6.0",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/commit-analyzer": "^11.1.0",
     "@semantic-release/git": "^10.0.1",
@@ -26,8 +26,8 @@
     "@types/lodash.isfunction": "^3.0.9",
     "@typescript-eslint/eslint-plugin": "^6.21.0",
     "@typescript-eslint/parser": "^6.21.0",
-    "@vitest/coverage-istanbul": "^2.1.3",
-    "bun-types": "^1.1.30",
+    "@vitest/coverage-istanbul": "^2.1.6",
+    "bun-types": "^1.1.37",
     "commitizen": "^4.3.1",
     "eslint": "8.57.0",
     "eslint-config-airbnb-typescript": "^17.1.0",
@@ -38,13 +38,13 @@
     "git-cz": "^4.9.0",
     "husky": "^8.0.3",
     "lint-staged": "^15.2.10",
-    "prettier": "^3.3.3",
+    "prettier": "^3.4.1",
     "rimraf": "^5.0.10",
-    "semantic-release": "^24.1.2",
-    "type-fest": "^4.26.1",
+    "semantic-release": "^24.2.0",
+    "type-fest": "^4.28.1",
     "typescript": "^5.0.0",
     "vite-tsconfig-paths": "^4.3.2",
-    "vitest": "^2.1.3"
+    "vitest": "^2.1.6"
   },
   "peerDependencies": {
     "typescript": "^5.0.0"

package.json

@@ -66,16 +66,21 @@ type PromiseSettledResult<T> =
   | PromiseFulfilledResult<T>
   | PromiseRejectedResult;
 
+type QueueTask = {
+  fulfilled: () => void;
+  rejected: () => void;
+};
+
 export class MyPromise<T = any> implements IMyPromise<T> {
   #state: ValueOf<typeof STATES> = STATES.PENDING;
 
+  #completed = false;
+
   #value: T | PromiseLike<T> | undefined = undefined;
 
   #reason: any = undefined;
 
-  #fulfilledCallbacksQueue: (() => void)[] = [];
-
-  #rejectedCallbacksQueue: (() => void)[] = [];
+  #callbacksQueue: QueueTask[] = [];
 
   // --- Resolve --------------------
   static resolve(): MyPromise<void>;
@@ -239,30 +244,24 @@ export class MyPromise<T = any> implements IMyPromise<T> {
 
     // Resolve -----
     const internalResolve = (value: T | PromiseLike<T>) => {
-      if (this.#state !== STATES.PENDING) return;
+      if (this.#completed) return;
+      this.#completed = true;
 
       this.#state = STATES.FULFILLED;
       this.#value = value;
 
-      this.#fulfilledCallbacksQueue.forEach((callback) => {
-        callback();
-      });
-
-      this.#fulfilledCallbacksQueue = [];
+      this.#executeCallbacksQueue();
     };
 
     // Reject -----
     const internalReject = (reason: any) => {
-      if (this.#state !== STATES.PENDING) return;
+      if (this.#completed) return;
+      this.#completed = true;
 
       this.#state = STATES.REJECTED;
       this.#reason = reason;
 
-      this.#rejectedCallbacksQueue.forEach((callback) => {
-        callback();
-      });
-
-      this.#fulfilledCallbacksQueue = [];
+      this.#executeCallbacksQueue();
     };
 
     // Constructor execution -----
@@ -282,12 +281,9 @@ export class MyPromise<T = any> implements IMyPromise<T> {
   ) {
     return new MyPromise((resolve, reject) => {
       if (this.#state === STATES.PENDING) {
-        this.#fulfilledCallbacksQueue.push(() => {
-          handleFulfilled(this.#value as T);
-        });
-
-        this.#rejectedCallbacksQueue.push(() => {
-          handleRejected(this.#reason);
+        this.#callbacksQueue.push({
+          fulfilled: () => handleFulfilled(this.#value as T),
+          rejected: () => handleRejected(this.#reason),
         });
       } else if (this.#state === STATES.FULFILLED) {
         if (isThenable(this.#value)) {
@@ -338,6 +334,25 @@ export class MyPromise<T = any> implements IMyPromise<T> {
     });
   }
 
+  #executeCallbacksQueue() {
+    let index = 0;
+    const chain = this.#callbacksQueue;
+
+    while (index !== chain.length) {
+      const { fulfilled, rejected } = chain[index];
+
+      if (this.#state === STATES.FULFILLED) {
+        fulfilled();
+      } else {
+        rejected();
+      }
+
+      index += 1;
+    }
+
+    this.#callbacksQueue = [];
+  }
+
   // --- Catch --------------------
   catch<TResult = never>(
     onrejected?: ((reason: any) => TResult | PromiseLike<TResult>) | null,