Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url package conflicts with browser global #3089

Closed
andylash opened this issue Nov 13, 2014 · 2 comments
Closed

Url package conflicts with browser global #3089

andylash opened this issue Nov 13, 2014 · 2 comments

Comments

@andylash
Copy link
Contributor

The url package exports a global called URL. This conflicts with the new DOM API: https://developer.mozilla.org/en-US/docs/Web/API/Window.URL#Browser_compatibility. I noticed this while using this filesaver library, where polymer has the same problem, but is planning to fix it: eligrey/FileSaver.js#97.

@glasser
Copy link
Contributor

glasser commented Dec 4, 2014

Well, hmm. If you don't use the url package directly in your app, it doesn't actually export the symbol as a global, but just as a local in your individual app, so you can still get at the DOM API via window.URL. (If you do use the url package directly in your app, then it does overwrite the global, in order to support the browser debugger console better.)

@abernix
Copy link
Contributor

abernix commented May 26, 2016

Closing this. With NPM support in Meteor now, the expectation at this point is that developers shouldn't use the Meteor url package directly, but instead use the url NPM package (which is what Meteor uses internally anyway).

url is already not documented in the new docs (for probably a very good reason), and I'd guess (personally) is one of the first candidates (due to it's simplicity) for replacement in the Meteor 1.5 NPM-oriented-release.

@abernix abernix closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants