-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The wiki suggestion to use "dynamic native tabs" using userChrome.css doesn't work with firefox 133 #1889
Comments
Even when using this exact userChrome snippet, I still see Firefox bringing up the native tabs. It even shows Sideberry as a "sidebar extension", so this looks like it is almost hard-coded behaviour to have them both visible (which is pretty strange, clearly the point should be that Firefox hands off things to the dedicated "sidebar extension" then). I would suspect this is a bug. I should perhaps mention that I am using the "vertical tabs" option inside Firefox, as that also fixes things like window controls. Under horizontal tabs (and with sidebar.revamp set to false), I think this fix works. |
I'm using horizontal tabs with sidebery. That fix above works fine in 133 using Gnome. I'm also using the firefox-gnome-theme and setting the sizes to 2.7em, 3.05em and 2.4em seems to fit better. |
Yeah, I decided to switch to horizontal tabs. Long-term, I think now that Firefox does support vertical stuff natively, perhaps Firefox could just allow extensions to swap in their own side bars instead of the native vertical bar, which would be the best of both world, where you get custom sidebar extensions without having to mess with userChrome at all. |
Please, although I have not mentioned, be aware that you have to set the configuration |
I found that this appears to work (using empty char for the preface). I used
|
Here's some css with animations working #main-window #TabsToolbar {⤶
··transition: visibility 0s 0s;⤶
}⤶
#main-window #TabsToolbar .toolbar-items {⤶
··overflow: hidden;⤶
··transition: height 0.3s 0.3s !important;⤶
}⤶
/* Default state: Set initial height to enable animation */⤶
#main-window #TabsToolbar .toolbar-items { height: 40px !important; }⤶
/* Hidden state: Hide native tabs strip */⤶
#main-window[titlepreface*="<200b>"] #TabsToolbar { visibility: collapse; transition: visibility 0s 0.6s !important }⤶
#main-window[titlepreface*="<200b>"] #TabsToolbar .toolbar-items { height: 0 !important; }⤶
/* Hidden state: Fix z-index of active pinned tabs */⤶
#main-window[titlepreface*="<200b>"] #tabbrowser-tabs { z-index: 0 !important; }⤶ |
I used the |
Tried what was available here but no real solution fix to get the tab-bar hiding when sidebery is active and showing when sidebery is inactive. The following code got it working again as it was meant to work prior to Firefox ver:133 release on Windows. NOTE: I may or may not have made changes to the values to fit my LibreWolf custom theme. The Min/Maximize & Close buttons should show cleanly on the UI. Tab-bar should completely hide. For those who opt to use/show the Title-bar, this should leave a small clean space between the navigation-toolbar thus the top of the URL-bar outline should show cleanly. I hope this helps others. `#main-window #TabsToolbar .toolbar-items { /* Default state: Set initial height to enable animation */ #main-window[uidensity="touch"] #TabsToolbar .toolbar-items { #main-window[uidensity="normal"] #TabsToolbar .toolbar-items { /* Hidden state: Hide native tabs strip / /* Hidden state: Fix z-index of active pinned tabs / }` |
Hi, I did another code that works, it's dynamic animated too. Sorry if something's it's off on my English, it's not my native. https://unicode-explorer.com/c/200B
|
Steps to reproduce
Actual behavior
When you open firefox 133 the tabs are not hidding when Sidebery is opened
Expected behavior
Firefox tabs should be hide when Sidebery is open.
After some research, I found that the
#titlebar
"selector" is removed from this version.I tried to update the userChrome.css and get to a new version that is working for me, but I can't change or submit a PR to change the wiki.
All that it's need is to update the selector to
.toolbar-items
like the following snippet.Please, note that I only tested on my machine and I'm no expert in CSS.
System
Xubuntu 22.04
Firefox version
133.0
Sidebery version
5.2.0
Logs
No response
The text was updated successfully, but these errors were encountered: