Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V5] [BUG] Active tab's highlight breaks after unpinning tab #1180

Closed
lkster opened this issue Aug 16, 2023 · 2 comments
Closed

[V5] [BUG] Active tab's highlight breaks after unpinning tab #1180

lkster opened this issue Aug 16, 2023 · 2 comments
Labels
reproduced: yes type: bug

Comments

@lkster
Copy link

lkster commented Aug 16, 2023

Steps to reproduce

  • Pin tab (if there's no pinned tab yet)
  • Unpin tab

Expected behavior

Highlighting active tabs works as expected

Actual behavior

Highlighting active tab no longer works. Tab that was active right before unpinning stays highlighted.

Debug info

After unpinning, data-active attribute no longer changes it's state. This however recovers itself for pinned tabs only if one is pinned back (then there are 2 highlighted tabs if pinned one is active)
@lkster lkster changed the title Active tab's highlight breaks after unpinning tab [V5] [BUG] Active tab's highlight breaks after unpinning tab Aug 16, 2023
@mbnuqw
Copy link
Owner

mbnuqw commented Sep 3, 2023

Fixed in f06b1f9 and 5cd5d76 (unreleased)

@mbnuqw
Copy link
Owner

mbnuqw commented Sep 20, 2023

Resolved in v5.0.0

@mbnuqw mbnuqw closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reproduced: yes type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbnuqw @lkster