Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGC rounding Float Parameters #9781

Closed
LowOrbitIonCannon opened this issue Jul 23, 2021 · 6 comments · Fixed by #10589
Closed

QGC rounding Float Parameters #9781

LowOrbitIonCannon opened this issue Jul 23, 2021 · 6 comments · Fixed by #10589

Comments

@LowOrbitIonCannon
Copy link

LowOrbitIonCannon commented Jul 23, 2021

Expected Behavior

QGC should show Float Parameters with decimal Places, even if there is no rule given for handling the decimal places.

Current Behavior

QGC shows Custom Parameters rounded to the nearest Integer.
FMU receives the correct Parameter in FLOAT. Also QGC recognizes that the Parameters on the FMU are not Rounded.
image (2)

Standard Parameters show correct behavior:
image (3)

Steps to Reproduce:

  1. Introduce Custom float Parameter
  2. Set value to something with decimal places

System Information

When posting bug reports, include the following information

Parameter Metadata in question:
PX4/PX4-Autopilot@95b9d2e

Detailed Description

I added custom YAML Parameters. When I change them in QGC, they'll be correctly set in the FMU but won't display properly.
adding decimal Metadata fixes the Display.

Log Files and Screenshots

Mavlink Console snapshot showing that the Parameters are correct on the FMU:
image (1)

@DonLakeFlyer

@jhiggason
Copy link

jhiggason commented Feb 20, 2023

I can confirm this bug and it caused me HUGE problems when setting up a drone because I didn't understand that even though I set a parameter...it wasn't displaying it properly...even though it was set properly. This needs to be fixed ASAP.

Edit: I was using the Daily build of QGroundControl as of Feb 13.

@DonLakeFlyer
Copy link
Contributor

Create a PX4 branch somewhere based on master which adds a custom parameter which fails like this that I can then compile and run in SITL and then I can try to fix this.

@jhiggason
Copy link

@DonLakeFlyer Not sure I 100% understand this- you just want me to branch the master? I was using the Daily build of QGC and Master of PX4. (As of like 2 weeks ago) Lots of Avoidance settings in QGC are what are not displaying properly. That and Ark Flow sensor settings. Both of these came from the Master build of PX4....

@DonLakeFlyer
Copy link
Contributor

Ok, so this bug talks about custom parameters, not standard PX4 parameters. If this happens on them as well then tell me a specific parameter which exists in regular px4 master which if I connect QGC to a SITL instance of that will show up in the parameter list. If it requires a specific SITL vehicle to test with let me know what that is.

@jhiggason
Copy link

jhiggason commented Feb 20, 2023

cp_dist is one. Rounds to whole numbers even though it allows for float. And again, when setting it in QGC- it works- but then it just doesn't display it properly. Like the field to view the parameter in QGC is dec instead of float. There are lots though that I ran into while working with it. Do you think we can just compare QGC and PX4 parameter field type values to ensure they are all matching?

@jhiggason
Copy link

You are the best for looking at this, Thank you for your hard work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants