Skip to content

Commit 1a5dff5

Browse files
Jordan Crouserobclark
Jordan Crouse
authored andcommitted
drm/msm: Don't allow zero sized buffer objects
Zero sized buffer objects tend to make various bits of the GEM infrastructure complain: WARNING: CPU: 1 PID: 2323 at drivers/gpu/drm/drm_mm.c:389 drm_mm_insert_node_generic+0x258/0x2f0 Modules linked in: CPU: 1 PID: 2323 Comm: drm-api-test Tainted: G W 4.9.0-rc4-00906-g693af44 torvalds#213 Hardware name: Qualcomm Technologies, Inc. DB820c (DT) task: ffff8000d7353400 task.stack: ffff8000d7720000 PC is at drm_mm_insert_node_generic+0x258/0x2f0 LR is at drm_vma_offset_add+0x4c/0x70 Zero sized buffers serve no appreciable value to the user so disallow them at create time. Signed-off-by: Jordan Crouse <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent f456d34 commit 1a5dff5

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/gpu/drm/msm/msm_gem.c

+6
Original file line numberDiff line numberDiff line change
@@ -812,6 +812,12 @@ struct drm_gem_object *msm_gem_new(struct drm_device *dev,
812812

813813
size = PAGE_ALIGN(size);
814814

815+
/* Disallow zero sized objects as they make the underlying
816+
* infrastructure grumpy
817+
*/
818+
if (size == 0)
819+
return ERR_PTR(-EINVAL);
820+
815821
ret = msm_gem_new_impl(dev, size, flags, NULL, &obj);
816822
if (ret)
817823
goto fail;

0 commit comments

Comments
 (0)