Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size of rows with submenu is not changeable #663

Closed
gson88 opened this issue Mar 25, 2021 · 6 comments
Closed

Font size of rows with submenu is not changeable #663

gson88 opened this issue Mar 25, 2021 · 6 comments

Comments

@gson88
Copy link

gson88 commented Mar 25, 2021

Hi.

It is no longer possible to change font-size or color of rows that contain a submenu.
Even though I set the size to 10, the rows with submenus look like they have size ~14.

Example output:

IOTA: $1.35|color="white" size="10"
--Qty: 1|color="white" size="10"
-----
--Total: $1|color="green" size="10"
1h:   -1.20%|color="red" size="10"
24h: -12.23%|color="red" size="10"
---
HBAR: $0.3014|color="white" size="10"
--Qty: 1|color="white" size="10"
-----
--Total: $1|color="green" size="10"
1h:   -0.76%|color="red" size="10"
24h: -5.80%|color="red" size="10"

Result:

image

Thanks for a great application.

I forgot, here are my specs
image

@matryer
Copy link
Owner

matryer commented Mar 26, 2021

@leaanthony Do we need to similar work that we did to the tray to the submenu items?

@leaanthony
Copy link
Collaborator

Thanks for raising this @gson88. I'll check, but it looks like it might be skipping submenu nodes for the stylised text. It would be an easy fix if it is, and I'm 99% sure that's the issue.

@leaanthony
Copy link
Collaborator

@gson88 - was as expected. Fix done. Will be in the next xbar release. Here's a demo partly using your output:
image

@gson88
Copy link
Author

gson88 commented Mar 26, 2021

@leaanthony Nice. Good work

@jebabin
Copy link

jebabin commented Mar 28, 2021

Hello, is the fix really in v2.0.34-beta as in the release note (I don't see a commit that looks to fix it) ? Even after upgrading I still have this issue, my example and the result bellow

Test
---
abcd | image=iVBORw0KGgoAAAANSUhEUgAAACIAAAAiAQMAAAAAiZmBAAAABGdBTUEAALGPC/xhBQAAAAFzUkdCAK7OHOkAAAFZaVRYdFhNTDpjb20uYWRvYmUueG1wAAAAAAA8eDp4bXBtZXRhIHhtbG5zOng9ImFkb2JlOm5zOm1ldGEvIiB4OnhtcHRrPSJYTVAgQ29yZSA2LjAuMCI+CiAgIDxyZGY6UkRGIHhtbG5zOnJkZj0iaHR0cDovL3d3dy53My5vcmcvMTk5OS8wMi8yMi1yZGYtc3ludGF4LW5zIyI+CiAgICAgIDxyZGY6RGVzY3JpcHRpb24gcmRmOmFib3V0PSIiCiAgICAgICAgICAgIHhtbG5zOnRpZmY9Imh0dHA6Ly9ucy5hZG9iZS5jb20vdGlmZi8xLjAvIj4KICAgICAgICAgPHRpZmY6T3JpZW50YXRpb24+MTwvdGlmZjpPcmllbnRhdGlvbj4KICAgICAgPC9yZGY6RGVzY3JpcHRpb24+CiAgIDwvcmRmOlJERj4KPC94OnhtcG1ldGE+Chle4QcAAAAJcEhZcwAACxMAAAsTAQCanBgAAAADUExURf8AABniCTcAAAALSURBVAgdYxhGAAAAzAABBmNdUQAAAABJRU5ErkJggg==
--dummy
def | color=red 
--dummy
ghi | size="10"
--dummy

Screenshot 2021-03-28 at 18 05 46

@leaanthony
Copy link
Collaborator

It wasn't in the last release - there was a mix up with branches. I've got a PR to merge the branches and can confirm the script you pasted shows this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants