-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich content in menu bar #630
Comments
It'll be a bit of a refactor but it shouldn't be impossible 😃 |
On the same note, BitBar supported Nerd Fonts, which allowed using custom icons: |
Thanks @omeraloni - you're right, I think that is related, don't you @leaanthony? |
I would think so, assuming you need to install nerd fonts on your system to make it work. |
@leaanthony yep, you need to install them to make it work |
@omeraloni we think this is fixed in the latest release, can you test it and let me know? |
@matryer It works, thank you. I didn't test custom fonts but specified font colour is now working on the last update. |
Thanks @furkantektas. |
Hi @matryer, Thanks for the huge update to bitbar. I just ported scripts from bitbar to xbar which does utilise nerd font and while the colour/font size is working fine, the nerd front is not being displayed properly. OS: 10.15.4 print(" | size=27 font='DejaVuSansMono Nerd Font Mono'")
print("---")
for alarm in alarms:
print("%s %s" % (alarm["Name"], alarm["State"])) Running the above script in both bitbar and xbar (left is bitbar and right is xbar): Seems like the custom font issue is still present, could we reopen this issue. Really appreciate all the work. Thanks, |
Hi @leaanthony, Thanks for the hint. The font is showing properly using the postscript location. Regarding the weird placement, I'm not really sure. It's actually slightly lower on my system when the font size is bigger...mostly likely either mine is an older version of the font or maybe OS version difference? The placement of the icon will also change when the font size increase/decrease. Not sure how this can be fixed unless there's a way to center the font? |
I'll have another look at it. On my system, it went higher the bigger it was. Almost like it only occupied the top half of the space allocated. I guess font icons will always be subject to local environmental differences, which is why images are the preceded solution. |
@kazhala - Just wanted to say thanks for bringing my attention to the font naming issue. I've made a change in Wails to allow the name to be more permissive and tried with your original script and it appears to be working as you originally expected:
I've pushed a change for xbar so this will be included in the next release. Thanks for helping us improve 👍 EDIT: Just found this thread that may explain why the icon looks small for me: ryanoasis/nerd-fonts#127 |
Hi @leaanthony, thank you for the hard work and quick action on the matter. Really appreciated! |
The Tray menu (the item that sits in the menu bar) does not support rich content (fonts, colours, etc.) unlike the menu items in the dropdown.
@leaanthony What's involved in getting this added to Wails?
The text was updated successfully, but these errors were encountered: