-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ping.10s.sh crashes xbar #1567
Comments
@leaanthony Is this related to other similar issues? |
Leave this with me to investigate 👍 |
Can't reproduce with latest. @Joshfindit if this still happens with latest, let us know 👍 |
@leaanthony It still crashes for me on latest, yes:
|
What OS version? That's so weird |
This is Do note as well:
|
Confirmed: it's the output. It crashes inconsistently when the script is simply
(Oddly: Sometimes it will show the colour) And crashes reliably when the script is
and I click on the
As one of the few people in the repo using High Sierra, I am perfectly comfortable with xbar simply discarding color information on older versions in order to avoid this crash. |
Thanks for the detailed information! I'm going to install High Sierra on my test machine and figure this out! |
So my initial tests confirm the crash. After a lot of debugging I can also confirm that it's to do with the way High Sierra deals with NSMutableStrings. There's quite a few reports online of this scenario causing problems. More investigation needed. |
What's kinda interesting is that not giving a colour does make all the menus work, but commenting out all the code related to colour doesn't change a thing. |
Really unfortunate that it sounds like a bug (or "feature") with High Sierra itself. I'm sad to say that with One new thing I accidentally came across: if I us |
Hi @Joshfindit |
@Joshfindit @beaudett I tracked down the issue last night and will be doing a Wails release later on tonight plus a PR for xbar. |
Hi @leaanthony |
Ah, that's a pain! That's the auto login check. I will look into this - EDIT: I'm not seeing that at all on High Sierra. Please provide more info on which scripts, etc. |
Awesome work @leaanthony, thank you 🎉 |
I'm thinking this has to do with the differences between xbar and BitBar
I'm up for updating this plugin myself if someone can point out the issue, but I would also like to suggest something in addition:
Let xbar fail gracefully and not crash when a script breaks.
The text was updated successfully, but these errors were encountered: