Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

store.(get|set)_type_stream_id_for_appservice(...) are not covered by tests #8603

Closed
Half-Shot opened this issue Oct 20, 2020 · 0 comments · Fixed by #8648
Closed

store.(get|set)_type_stream_id_for_appservice(...) are not covered by tests #8603

Half-Shot opened this issue Oct 20, 2020 · 0 comments · Fixed by #8648
Assignees
@Half-Shot
Labels
A-Application-Service Related to AS support A-Testing Issues related to testing in complement, synapse, etc

Comments

@Half-Shot
Copy link
Collaborator

Which means that a future schema/code change could break these functions and we wouldn't know. This is a reminder issue to remind me to fix it ASAP.
@Half-Shot Half-Shot self-assigned this Oct 20, 2020
@Half-Shot Half-Shot added testing A-Application-Service Related to AS support labels Oct 20, 2020
@Half-Shot Half-Shot mentioned this issue Oct 25, 2020
Merged
@richvdh richvdh added the A-Testing Issues related to testing in complement, synapse, etc label Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Half-Shot Half-Shot

Labels
A-Application-Service Related to AS support A-Testing Issues related to testing in complement, synapse, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix get|set_type_stream_id_for_appservice store functions matrix-org/synapse
2 participants
@richvdh @Half-Shot