|
| 1 | +from unittest.mock import patch |
| 2 | + |
| 3 | +from synapse.api.room_versions import RoomVersions |
| 4 | +from synapse.push.bulk_push_rule_evaluator import BulkPushRuleEvaluator |
| 5 | +from synapse.rest import admin |
| 6 | +from synapse.rest.client import login, register, room |
| 7 | +from synapse.types import create_requester |
| 8 | + |
| 9 | +from tests import unittest |
| 10 | + |
| 11 | + |
| 12 | +class TestBulkPushRuleEvaluator(unittest.HomeserverTestCase): |
| 13 | + |
| 14 | + servlets = [ |
| 15 | + admin.register_servlets_for_client_rest_resource, |
| 16 | + room.register_servlets, |
| 17 | + login.register_servlets, |
| 18 | + register.register_servlets, |
| 19 | + ] |
| 20 | + |
| 21 | + def test_action_for_event_by_user_handles_noninteger_power_levels(self) -> None: |
| 22 | + """We should convert floats and strings to integers before passing to Rust. |
| 23 | +
|
| 24 | + Reproduces #14060. |
| 25 | +
|
| 26 | + A lack of validation: the gift that keeps on giving. |
| 27 | + """ |
| 28 | + # Create a new user and room. |
| 29 | + alice = self.register_user("alice", "pass") |
| 30 | + token = self.login(alice, "pass") |
| 31 | + |
| 32 | + room_id = self.helper.create_room_as( |
| 33 | + alice, room_version=RoomVersions.V9.identifier, tok=token |
| 34 | + ) |
| 35 | + |
| 36 | + # Alter the power levels in that room to include stringy and floaty levels. |
| 37 | + # We need to suppress the validation logic or else it will reject these dodgy |
| 38 | + # values. (Presumably this validation was not always present.) |
| 39 | + event_creation_handler = self.hs.get_event_creation_handler() |
| 40 | + requester = create_requester(alice) |
| 41 | + with patch("synapse.events.validator.validate_canonicaljson"), patch( |
| 42 | + "synapse.events.validator.jsonschema.validate" |
| 43 | + ): |
| 44 | + self.helper.send_state( |
| 45 | + room_id, |
| 46 | + "m.room.power_levels", |
| 47 | + { |
| 48 | + "users": {alice: "100"}, # stringy |
| 49 | + "notifications": {"room": 100.0}, # float |
| 50 | + }, |
| 51 | + token, |
| 52 | + state_key="", |
| 53 | + ) |
| 54 | + |
| 55 | + # Create a new message event, and try to evaluate it under the dodgy |
| 56 | + # power level event. |
| 57 | + event, context = self.get_success( |
| 58 | + event_creation_handler.create_event( |
| 59 | + requester, |
| 60 | + { |
| 61 | + "type": "m.room.message", |
| 62 | + "room_id": room_id, |
| 63 | + "content": { |
| 64 | + "msgtype": "m.text", |
| 65 | + "body": "helo", |
| 66 | + }, |
| 67 | + "sender": alice, |
| 68 | + }, |
| 69 | + ) |
| 70 | + ) |
| 71 | + |
| 72 | + bulk_evaluator = BulkPushRuleEvaluator(self.hs) |
| 73 | + # should not raise |
| 74 | + self.get_success(bulk_evaluator.action_for_event_by_user(event, context)) |
0 commit comments