Ecommerce Orders Conversion Rate Rounding Error

[beamylake]

Hello,
we've encountered an rounding error (again) when displaying the ecommerce overview in german

Here's the english version, where everything is looking as expected:

And here is the german version, where the Ecommerce Orders Conversion Rate gets rounded down to 0%:

It feels like this problem might be a "leftover" of #15200

We are using Matomo 3.13.3 and the rest of our setup is still as described in #15240

Please let me know if you need any further information and thanks in advance for your efforts!

[tsteur]

Thanks @beamylake we'll have a look to see if we can reproduce this.

[pebosi]

I have the same problem on my current install:
in NumberFormater.php the method formatNumberWithPattern calls "replaceSymbols"
The php strtr function has a strange behaviour here. When i return the value before the call i get a correct result.
Can't reproduce on local machine, so maybe a specific php / server conf problem.

[sgiehl]

The php strtr function has a strange behaviour here. When i return the value before the call i get a correct result.

I would more likely assume the number formatting is done twice maybe. And after the number is converted to a german format it gets truncated when it's formatted again.

@pebosi could you try switching the language to english and check if the same problem exists?

[pebosi]

Would be nice to have the whole NumberFormat stuff based on Intl Component / Extension, with upgrade to Twig 3 #15573

[pebosi]

See the screenshots

[pebosi]

And now when returning the value above this line
$value = $this->replaceSymbols($value);

Eng:

Deu:

[pebosi]

Matomo version: 3.13.3
MySQL version: 10.0.38-MariaDB-0ubuntu0.16.04.1
PHP version: 7.3.15-3+ubuntu16.04.1+deb.sury.org+1

[pebosi]

The second screenshots show the correct value (maybe its better to have 2 digits like in the graph tooltip). But the dot is not replaced with a comma in german...

[sgiehl]

you try applying that linked PR. that should fix the issue

[pebosi]

Works!

[beamylake]

We can confirm, it's working for us too!
Thnx!