Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config file for CLI #101

Closed
3 tasks done
SlnPons opened this issue Sep 2, 2024 · 1 comment · Fixed by #131
Closed
3 tasks done

Create config file for CLI #101

SlnPons opened this issue Sep 2, 2024 · 1 comment · Fixed by #131
Assignees

Comments

@SlnPons
Copy link
Collaborator

SlnPons commented Sep 2, 2024

Context
Create a config file to store needed info to be able to choose the parameters that can changed (node, chunk size, ...)

How to

  • Check if there is an official way to handle config files using Commander
  • Check if more options can be put into the config file (address? no need for wallet Add signing w/ secret key using CLI #102 )
  • Implement the config handling based on the found solution

Tech info

# The URL to the node to connect to
node_url: "https://buildnet.massa.net/api/v2"
# The max number of slots to wait for an operations to be included into a block
expiry: 9
@pivilartisant
Copy link
Contributor

pivilartisant commented Sep 27, 2024

  1. there seems to be a couple of issue on the subject of natively using config files Add support for config files tj/commander.js#1584 (2021) & [Help] Struggling to implement configuration file options tj/commander.js#1843 (2023) although there is no super clear api like other cli frameworks.

Dans un premier temps, I'll make a straight forward implementation to identify the correct flow, logic and make sure we have all must have's. I will then procede to improve the code and prettify the cli output.

@pivilartisant pivilartisant linked a pull request Sep 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants