Skip to content

Commit bf90360

Browse files
tniessenmartenrichter
authored andcommitted
src: remove erroneous default argument in RadixTree
This default argument can never benefit any potential caller because any call site that occurs after this definition will result in a compiler error due to RadixTree::Lookup(const std::string_view&) now being an ambiguous call target. PR-URL: nodejs#50736 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 4154929 commit bf90360

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/permission/fs_permission.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ FSPermission::RadixTree::~RadixTree() {
172172
}
173173

174174
bool FSPermission::RadixTree::Lookup(const std::string_view& s,
175-
bool when_empty_return = false) const {
175+
bool when_empty_return) const {
176176
FSPermission::RadixTree::Node* current_node = root_node_;
177177
if (current_node->children.size() == 0) {
178178
return when_empty_return;

0 commit comments

Comments
 (0)