jupyter multirender get rid of embedWindow

Author: marcomusy

vedo/backends.py

@@ -17,52 +17,51 @@
 from vedo.mesh import Mesh
 from vedo.volume import Volume
 
-__doc__ = """
-Submodule to delegate notebook rendering
-"""
+__doc__ = """Submodule to delegate notebook rendering"""
 
 __all__ = []
 
+
 ############################################################################################
 def get_notebook_backend(actors2show=()):
     """Return the appropriate notebook viewer"""
 
     plt = vedo.plotter_instance
 
-    if isinstance(plt.shape, str) or sum(plt.shape) > 2 and vedo.notebook_backend != '2d':
+    if isinstance(plt.shape, str) or sum(plt.shape) > 2 and settings.default_backend != '2d':
         vedo.logger.error(
-            f"Multirendering is not supported for jupyter backend: {vedo.notebook_backend}"
+            f"Multirendering is not supported for jupyter backend: {settings.default_backend}"
         )
 
     #########################################
-    if "itk" in vedo.notebook_backend:
+    if "itk" in settings.default_backend:
         return start_itkwidgets(actors2show)
 
     #########################################
-    elif vedo.notebook_backend == "k3d":
+    elif settings.default_backend == "k3d":
         return start_k3d(actors2show)
 
     #########################################
-    elif vedo.notebook_backend == "panel":
+    elif settings.default_backend == "panel":
         return start_panel()
 
     #########################################
-    elif vedo.notebook_backend.startswith("ipyvtk"):
+    elif settings.default_backend.startswith("ipyvtk"):
         return start_ipyvtklink()
 
     #########################################
-    elif vedo.notebook_backend == "ipygany":
+    elif settings.default_backend == "ipygany":
         return start_ipygany(actors2show)
 
     #########################################
-    elif vedo.notebook_backend == "2d":
+    elif settings.default_backend == "2d":
         return start_2d()
 
     #########################################
-    # elif vedo.notebook_backend.startswith("pythree"): #todo
+    # elif settings.default_backend.startswith("pythree"): #todo
     #     return start_pythreejs(actors2show)
 
-    vedo.logger.error(f"Unknown jupyter backend: {vedo.notebook_backend}")
+    vedo.logger.error(f"Unknown jupyter backend: {settings.default_backend}")
     return None
 
 
@@ -72,7 +71,7 @@ def start_itkwidgets(actors2show):
     #  /blob/master/itkwidgets/widget_viewer.py
     try:
         from itkwidgets import view
-    except ModuleNotFoundError("Cannot find itkwidgets"):
+    except ModuleNotFoundError("Cannot find itkwidgets, try:\n> pip install itkwidgets"):
         return None
 
     vedo.notebook_plotter = view(
@@ -90,7 +89,9 @@ def start_k3d(actors2show):
     # https://github.com/K3D-tools/K3D-jupyter
     try:
         import k3d
-    except ModuleNotFoundError("Cannot find k3d, install with:  pip install k3d"):
+        if str(k3d.__version__) != "2.7.4":
+            vedo.logger.warning("Only k3d version 2.7.4 is currently supported")
+    except ModuleNotFoundError("Cannot find k3d, install with:  pip install k3d==2.7.4"):
         return None
 
     plt = vedo.plotter_instance
@@ -299,7 +300,8 @@ def start_panel():
 
     try:
         import panel  # https://panel.pyviz.org/reference/panes/VTK.html
-    except ImportError("panel is not installed"):
+        panel.extension("vtk")
+    except ImportError("panel is not installed, try:\n> pip install panel"):
         return None
 
     plt = vedo.plotter_instance
@@ -321,7 +323,7 @@ def start_ipyvtklink():
 
     try:
         from ipyvtklink.viewer import ViewInteractiveWidget
-    except ImportError("ipyvtklink is not installed"):
+    except ImportError("ipyvtklink is not installed, try:\n> pip install ipyvtklink"):
         return None
 
     plt = vedo.plotter_instance
@@ -344,7 +346,7 @@ def start_ipygany(actors2show):
         from ipygany import PolyMesh, Scene, IsoColor, RGB, Component
         from ipygany import Alpha, ColorBar, colormaps, PointCloud
         from ipywidgets import FloatRangeSlider, Dropdown, VBox, AppLayout, jslink
-    except ImportError("ipygany is not installed"):
+    except ImportError("ipygany is not installed, try:\n> pip install ipygany"):
         return None
 
     plt = vedo.plotter_instance

vedo/plotter.py

@@ -30,81 +30,6 @@
 ]
 
 
-##################################################################################
-def _embed_window(backend="ipyvtk"):
-    # check availability of backend by just returning its name
-
-    if backend is None:
-        return vedo.settings.default_backend  ####################
-
-    else:
-
-        if any(["SPYDER" in name for name in os.environ]):
-            return "vtk"
-
-        try:
-            get_ipython()
-        except NameError:
-            return "vtk"
-
-    backend = backend.lower()
-
-    if backend == "vtk":
-        return backend
-
-    elif backend == "k3d":
-        try:
-            import k3d
-            if str(k3d.__version__) != "2.7.4":
-                vedo.logger.warning("Only k3d version 2.7.4 is currently supported")
-            return backend
-
-        except ModuleNotFoundError:
-            vedo.logger.error("Could not load k3d try:\n> pip install k3d==2.7.4")
-            print(flush=True)
-
-    elif "ipygany" in backend:  # ipygany
-        try:
-            import ipygany
-            return backend
-        except ModuleNotFoundError:
-            vedo.logger.error("Could not load ipygany try:\n> pip install ipygany")
-            print(flush=True)
-
-    elif "itk" in backend:  # itkwidgets
-        try:
-            import itkwidgets
-            return backend
-        except ModuleNotFoundError:
-            vedo.logger.error('Could not load itkwidgets try:\n> pip install itkwidgets')
-            print(flush=True)
-
-    elif backend.lower() == "2d":
-        return backend
-
-    elif backend == "panel":
-        try:
-            import panel
-            panel.extension("vtk")
-            return backend
-        except ModuleNotFoundError:
-            vedo.logger.error("Could not load panel try:\n> pip install panel")
-
-    elif "ipyvtk" in backend:
-        try:
-            from ipyvtklink.viewer import ViewInteractiveWidget
-            return backend
-        except ModuleNotFoundError:
-            vedo.logger.error('Could not load ipyvtklink try:\n> pip install ipyvtklink')
-            print(flush=True)
-
-    else:
-        vedo.logger.error("Unknown backend" + str(backend))
-        raise RuntimeError()
-
-    return None
-
-
 ########################################################################################################
 def show(
         *actors,
@@ -131,7 +56,7 @@ def show(
         mode=0,
         q=False,
         new=False,
-        backend=None,
+        # backend=None,
     ):
     """
     Create on the fly an instance of class Plotter and show the object(s) provided.
@@ -295,7 +220,7 @@ def show(
             offscreen=offscreen,
             bg=bg,
             bg2=bg2,
-            backend=backend,
+            # backend=backend,
         )
 
     # use _plt_to_return because plt.show() can return a k3d/panel plot
@@ -444,11 +369,9 @@ def __init__(
             offscreen=False,
             qt_widget=None,
             wx_widget=None,
-            backend=None,
+            # backend=None,
         ):
 
-        vedo.notebook_backend = _embed_window(backend)
-
         vedo.plotter_instance = self
 
         if qt_widget is not None:
@@ -513,13 +436,13 @@ def __init__(
         self._repeatingtimer_id = None
 
         #####################################################################
-        if vedo.notebook_backend != 'vtk':
-            if vedo.notebook_backend == "2d":
+        if settings.default_backend != 'vtk':
+            if settings.default_backend == "2d":
                 self.offscreen = True
                 if self.size == "auto":
                     self.size = (800, 600)
 
-            elif vedo.notebook_backend == "k3d" or "ipygany" in vedo.notebook_backend:
+            elif settings.default_backend == "k3d" or "ipygany" in settings.default_backend:
                 self._interactive = False
                 self.interactor = None
                 self.window = None
@@ -804,7 +727,7 @@ def __init__(
             return #################
             ########################
 
-        if vedo.notebook_backend == "panel":
+        if settings.default_backend == "panel":
             ########################
             return #################
             ########################
@@ -2870,7 +2793,7 @@ def show(
             else:
                 self.window.SetSize(int(self.size[0]), int(self.size[1]))
 
-        if vedo.notebook_backend == 'vtk':
+        if settings.default_backend == 'vtk':
             if str(bg).endswith(".hdr"):
                 self._add_skybox(bg)
             else:
@@ -2925,8 +2848,8 @@ def show(
                 pass
 
         # Backend ###############################################################
-        if vedo.notebook_backend != 'vtk':
-            if vedo.notebook_backend in ["k3d", "ipygany", "itkwidgets"]:
+        if settings.default_backend != 'vtk':
+            if settings.default_backend in ["k3d", "ipygany", "itkwidgets"]:
                 return backends.get_notebook_backend(self.actors)
         #########################################################################
 
@@ -2996,7 +2919,7 @@ def show(
                 addons.add_global_axes(self.axes)
 
         # panel #################################################################
-        if vedo.notebook_backend in ["panel", "ipyvtk"]:
+        if settings.default_backend in ["panel", "ipyvtk"]:
             return backends.get_notebook_backend()
         #########################################################################
 
@@ -3069,7 +2992,7 @@ def show(
         self.window.SetWindowName(self.title)
 
         # 2d ####################################################################
-        if vedo.notebook_backend == "2d":
+        if settings.default_backend == "2d":
             return backends.get_notebook_backend()
         #########################################################################