IE11: Object doesn't support property or method 'includes'

[jonaseberle]

When including the geocoder, e.g. on https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder/ ,
IE11 says Object doesn't support property or method 'includes'

I will investigate further to see how this could be circumvented. Happy for any idea.

[andrewharvey]

Good catch! It looks like it's coming from

mapbox-gl-geocoder/lib/events.js

Line 210 in 17f2818

if (!this.origin.includes('api.mapbox.com')) return false;

confirming String.includes isn't supported on IE, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes

For the time being you can try v3.1.1 which should work.

@scottsfarley93 did you want to address this?

[jonaseberle]

Thank you @andrewharvey - that circumvents that problem but v3.1.1 uses Promises which IE11 does not have.
3.1.1 with this polyfill https://www.npmjs.com/package/promise-polyfill works.

[andrewharvey]

True, versions later than v2.3.0 need a promise-polyfill for older browsers. This stems from https://github.com/mapbox/mapbox-sdk-js#installation. We should do a better job of documenting this in the README, similar to https://github.com/mapbox/mapbox-sdk-js#installation.

[scottsfarley93]

I can fix this in the minor refactor I'm doing in #189.

I wonder if we can add some tests that capture regressions on IE11 going forward.

[scottsfarley93]

This should now be resolved in v3.1.6.