Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKO - Ikoria: Lair of Behemoths Set Card Implementation Tracking #6390

Open
theelk801 opened this issue Apr 2, 2020 · 109 comments · May be fixed by #8733
Open

IKO - Ikoria: Lair of Behemoths Set Card Implementation Tracking #6390

theelk801 opened this issue Apr 2, 2020 · 109 comments · May be fixed by #8733
Labels
tracking set Set card implementation tracking

Comments

@theelk801
Copy link
Contributor

theelk801 commented Apr 2, 2020

Note: The mutate mechanic is still in progress, so cards with mutate are not actually available right now

Mark cards you're working on in the second post of this issue.
If you can't check things off, leave a comment instead.
Once the card is committed, check off the card here to show that it's finished.
Don't worry about adding new spoilers to this list, it's generated by a script.

All Sets

Unimplemented Cards

Implemented Cards

Click to expand
@theelk801 theelk801 added the tracking set Set card implementation tracking label Apr 2, 2020
@theelk801
Copy link
Contributor Author

theelk801 commented Apr 2, 2020

@theelk801
Copy link
Contributor Author

theelk801 commented Apr 2, 2020

Additional Task:

  • Implement Mutate (right now I'm implementing the cards with nonfunctional versions of the abilities) works on: JayDi85 Mutate Cards #7623
  • Implement Companion
  • Implement ability counters

@JayDi85 JayDi85 pinned this issue Apr 2, 2020
@JayDi85
Copy link
Member

JayDi85 commented Apr 6, 2020

@theelk801 don't add cards with mutate to completed list or add extra list for that cards in first post. It's confusing (cards "completed", but they don't).

@theelk801
Copy link
Contributor Author

Yeah, I'm gonna add a filter like I had with Adventures, I just hadn't done it yet.

@emerald000
Copy link
Contributor

Has someone started working on Mutate/Companion or should I do it?

@theelk801
Copy link
Contributor Author

I haven't gotten to it yet but if you want to then go for it.

@emerald000
Copy link
Contributor

Alright, I will start with the easy one (Companion) and see how I feel about Mutate afterwards.

@theelk801
Copy link
Contributor Author

Yeah, that one's definitely easier but both seem like they're doable.

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

I'm gona try code up the rest of the cards today.

@theelk801
Copy link
Contributor Author

Awesome, just let me know which cards you're working on.

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

tbh im struggling to get xmage working in eclipse so I can work on it im pretty new to github

@theelk801
Copy link
Contributor Author

have you been following the guide on the wiki?

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

ye I should get there

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

Its not compiling in maven for some reason

@drowinternet
Copy link
Contributor

Hi, just wanted to chime in. I tried to compile the client last week on Intellij and VSC and couldn't get it to finish- just like Emigara. Would love to know if there is a solution since I completed a couple cards but didn't submit because I couldn't play test them.

@theelk801
Copy link
Contributor Author

what errors did it throw?

@JayDi85
Copy link
Member

JayDi85 commented Apr 11, 2020

I'll try to implement mutate ability

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

I'm trying to do it through the wizard for importing from git on eclipse

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

if i can get this working i could have all the cards implemented tomorrow if you can get mutate implemented then get companion implemented. Then we test and see if we can get ikoria onto xmage before it drops on arena

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

I got in but cant playtest i can however create the implementations and send them to someone who can test

@theelk801
Copy link
Contributor Author

Just implement the cards and open a pull request.

@drowinternet
Copy link
Contributor

@theelk801 The client hangs when trying to load symbols when running in IntelligJ. It looked like the mavin install and running the server completed successfully.

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

im working on mythos of snapdax atm and using tragic arrogance as a guide but wondering how on earth to change the effect to let you choose

@theelk801
Copy link
Contributor Author

You can just have a different player make the choice

@theelk801
Copy link
Contributor Author

@drowinternet have you followed the wiki guide? I think you need to allocate more ram

@drowinternet
Copy link
Contributor

@theelk801 I'll have another look. I just updated the setting per the github guide

@Emigara
Copy link
Contributor

Emigara commented Apr 11, 2020

MythosOfSnapdax.txt

I havn't figured out yet how to commit to github so I uploaded code as txt file, could you test this for me until i figure out how to setup properly

@drowinternet
Copy link
Contributor

just did a pull for 'back for more'. first card so will wait a bit to take another

@Rastael
Copy link

Rastael commented May 17, 2020

Did you use the beta server?

@fearphage
Copy link
Contributor

Tried numerous times. I've got the server version mismatch error numerous times as well as just not being able to connect. I'll just wait patiently I suppose.

I did find the beta version of the client which let me import the new IKO cards though... so part of the way there.

@DominusMaximus
Copy link

DominusMaximus commented May 23, 2020

I put an Agent of Treachery on the stack. In response, my opponent used Lurrus of the Dream-Den's ability to cast a Spectral Sailor with flash from their graveyard. After gaining control of the Lurrus with the Agent, I was unable to cast a Gilded Goose from my own graveyard. It seems it was counting the Spectral Sailor my opponent had cast as the one permanent spell per turn. On subsequent turns, Lurrus worked correctly under my control.

@superwill123
Copy link

@superwill123 They have implemented available IKO cards into the beta client. Play on the beta if you want to play with some IKO cards.

While this IS an option, and I mean no disrespect in what I am about to say, but in all honesty, if one doesn't want to play on a beta client but wants to play with new cars that are ready for release, they shouldn't have be forced to download something they don't want to download or have to wait past the start of spoiler season of the next set to play cards that have existed in paper. So unless I'm mistaken in some way or another (if so, please do correct me), it should be possible to add all the non-mutate cards into the non-beta client and release it like that, right?

TL;DR claiming that you should jump to another version of the game just because you want to wait for all the cards to be finished is not a good business practice

@Toshenko
Copy link

hey i love xmage, i'm supporting and donate for this wonderful project. Please communicate on what's happening in studio, i can't wait playing my new modern and impossible to charge a list on the beta...

@DominusMaximus
Copy link

TL;DR claiming that you should jump to another version of the game just because you want to wait for all the cards to be finished is not a good business practice

The Beta serves as a first run of newly created and implemented cards and mechanics. It allows players to report bugs, and programmers to correct errors or interactions with quirks! (before landing on the "stable" release.) Once downloaded, the Beta easily updates itself, and with portable Java and Java Launcher (portableapps.com), one can create a portable Beta with all images that easily updates itself. And if you add a 2nd folder containing the stable release, you can simply choose which portable client to use.

@htrajan
Copy link
Contributor

htrajan commented Jun 2, 2020

Any way I can help out on mutate?

@superwill123
Copy link

The Beta serves as a first run of newly created and implemented cards and mechanics. It allows players to report bugs, and programmers to correct errors or interactions with quirks! (before landing on the "stable" release.) Once downloaded, the Beta easily updates itself, and with portable Java and Java Launcher (portableapps.com), one can create a portable Beta with all images that easily updates itself. And if you add a 2nd folder containing the stable release, you can simply choose which portable client to use.

Oh, I'm not doubting the capabilities of the beta server. I'm just saying that you shouldn't force people to download an entirely new client just to play with cards that have been out for MONTHS when they are clearly ready to be released to the public in the non-beta version of the game.

@sirjonas
Copy link

sirjonas commented Jun 8, 2020

Any news about the cards going live? I saw that there are only 2 cards left.

@JayDi85
Copy link
Member

JayDi85 commented Jun 8, 2020 via email

@sirjonas
Copy link

sirjonas commented Jun 8, 2020

@sirjonas new release will be in 1 day. C20 plus IKO (without mutate cards).

OH REALLY? Thats great news! Where did you get that info? Thanks for sharing

@JayDi85
Copy link
Member

JayDi85 commented Jun 8, 2020

@sirjonas I'm preparing what's new docs and some little commits now. After that new release will be ready.

@fearphage
Copy link
Contributor

fearphage commented Jun 11, 2020

new release will be in 1 day. C20 plus IKO (without mutate cards).

I'm preparing what's new docs and some little commits now. After that new release will be ready.

I just checked and I still can't important IKO cards on the stable server. Is there something I can watch/follow/subscribe to to see when this lands?

@magefree magefree deleted a comment from superwill123 Jun 12, 2020
@Kovo
Copy link

Kovo commented Jun 14, 2020

Still no release?

@superwill123
Copy link

Still no release?

Still no release. My guess is that they're implementing the new "commander dies" rules, which I can respect

@sirjonas
Copy link

Any news? It would be Nice to know whats happening.

@sirjonas
Copy link

sirjonas commented Jun 19, 2020

Any news? Its okay to say its not ready yet, we Just want to know something!

@sumsarz
Copy link

sumsarz commented Jun 20, 2020

It's not ready, and will be released when it's released.

There, happy?

@notarpietrodavide
Copy link

It's not ready, and will be released when it's released.

There, happy?

People asking for info on a new release is actually a good thing for the project, it means people are interested in this.
Would xmage even exist without people being interested in using it ?

Besides, it's been released 30 mins ago :D !

Many thanks to the devs !

@JayDi85
Copy link
Member

JayDi85 commented Jun 20, 2020

I apologize for the delay in the release. Now everything is ready and the new version is installed on the server.

@ghvanderweg
Copy link

@JayDi85 any word on when mutate will be ready for release? :)

@LotusWalker
Copy link

Any thoughts on when Mutate might be ready for release?

@JayDi85
Copy link
Member

JayDi85 commented Aug 27, 2020

Nope, it's under development. You can find more info and testing version in forum's topic.

@jontaru
Copy link
Contributor

jontaru commented May 14, 2023

Seems like mutate progress was pretty much lost? The post on slightlymagic had a link to the latest code base but it is no longer a valid link and seems like it has been 2 years without any activity or progress on the mutate ability sadly.

Any way we can start working on it again ?

@Grath
Copy link
Contributor

Grath commented May 14, 2023

There's #8733 which has substantial open issues still, and has major unresolved implications around targeting, attaching cards, handling effects... Feel free to pick up working on that pull request to see if you can make Mutate actually work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking set Set card implementation tracking
Projects
None yet
Development

Successfully merging a pull request may close this issue.