Skip to content

Commit 9297a4e

Browse files
committed
Remove regression test for #340
This test tested that certain updates to internal state didn't trigger re-render assertions. However, firing tasks inside a getter is a side-effect not really allowed under the autotrack system, and should not be supported.
1 parent 1fdc2e1 commit 9297a4e

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

tests/integration/no-render-breaking-test.js

-27
Original file line numberDiff line numberDiff line change
@@ -44,32 +44,5 @@ module('Integration | no render breaking', function(hooks) {
4444
`);
4545
assert.ok(true, "Renders");
4646
});
47-
48-
test('Issue #340 | internal task state updates in cancellation do not trigger re-render assertions w/ auto-tracking', async function(assert) {
49-
assert.expect(1);
50-
51-
this.owner.register(
52-
'component:e-c-test',
53-
Component.extend({
54-
layout: hbs`<div>{{this.value}}</div>`,
55-
56-
get value() {
57-
this._super(...arguments);
58-
59-
this.exampleTask.perform();
60-
this.exampleTask.perform();
61-
62-
return "value";
63-
},
64-
65-
exampleTask: task(function*() {
66-
yield timeout(100);
67-
}).restartable()
68-
})
69-
);
70-
71-
await render(hbs`<ECTest />`);
72-
assert.ok(true, "Renders");
73-
});
7447
}
7548
});

0 commit comments

Comments
 (0)